Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision"

From	Colin Ian King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision"
Date	2017-06-13 12:50 +0200
Message-ID	<tRRyx-6SG-9@gated-at.bofh.it> (permalink)
References	<tRPQ5-5MF-7@gated-at.bofh.it> <tRRoS-6Pq-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 13/06/17 11:36, Joe Perches wrote:
> On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Trivial fix to spelling mistake in seq_printf message
> 
> Hey Colin.
> 
> Fixing spelling typos is a good thing, but is it a
> good thing to change possibly API dependent output
> in seq_ calls?

Considering it's in -next and has not landed in upstream I supposed it
was better to fix it now before it landed in Linus' repo.

Colin

> 
>> diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c
> []
>> @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v)
>>  	struct nitrox_device *ndev = s->private;
>>  
>>  	seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx);
>> -	seq_printf(s, "  Revsion ID: 0x%0x\n", ndev->hw.revision_id);
>> +	seq_printf(s, "  Revision ID: 0x%0x\n", ndev->hw.revision_id);
>>  	seq_printf(s, "  Cores [AE: %u  SE: %u]\n",
>>  		   ndev->hw.ae_cores, ndev->hw.se_cores);
>>  	seq_printf(s, "  Number of Queues: %u\n", ndev->nr_queues);
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Thread

[PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision" Colin King <colin.king@canonical.com> - 2017-06-13 11:00 +0200
  Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake  "Revsion" -> "Revision" Joe Perches <joe@perches.com> - 2017-06-13 12:40 +0200
    Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake  "Revsion" -> "Revision" Colin Ian King <colin.king@canonical.com> - 2017-06-13 12:50 +0200
      Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake  "Revsion" -> "Revision" Joe Perches <joe@perches.com> - 2017-06-13 12:50 +0200

csiph-web