Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1646730 > unrolled thread
| Started by | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| First post | 2017-05-22 13:00 +0200 |
| Last post | 2017-05-22 19:20 +0200 |
| Articles | 14 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 13:00 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:20 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:30 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:40 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:40 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:50 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Lee Jones <lee.jones@linaro.org> - 2017-05-22 20:30 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 20:40 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 20:50 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 21:40 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:40 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:30 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:30 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:20 +0200
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Date | 2017-05-22 13:00 +0200 |
| Subject | [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency |
| Message-ID | <tJTe9-4Fe-3@gated-at.bofh.it> |
Avoids reimplementation of DMI matching in intel_quark_i2c_setup.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
drivers/mfd/intel_quark_i2c_gpio.c | 33 +++++++++++++--------------------
1 file changed, 13 insertions(+), 20 deletions(-)
diff --git a/drivers/mfd/intel_quark_i2c_gpio.c b/drivers/mfd/intel_quark_i2c_gpio.c
index 7946d6e38b87..050061320377 100644
--- a/drivers/mfd/intel_quark_i2c_gpio.c
+++ b/drivers/mfd/intel_quark_i2c_gpio.c
@@ -58,19 +58,18 @@ struct intel_quark_mfd {
struct clk_lookup *i2c_clk_lookup;
};
-struct i2c_mode_info {
- const char *name;
- unsigned int i2c_scl_freq;
-};
-
-static const struct i2c_mode_info platform_i2c_mode_info[] = {
+static const struct dmi_system_id dmi_platform_info[] = {
{
- .name = "Galileo",
- .i2c_scl_freq = 100000,
+ .matches = {
+ DMI_EXACT_MATCH(DMI_BOARD_NAME, "Galileo"),
+ },
+ .driver_data = (void *)100000,
},
{
- .name = "GalileoGen2",
- .i2c_scl_freq = 400000,
+ .matches = {
+ DMI_EXACT_MATCH(DMI_BOARD_NAME, "GalileoGen2"),
+ },
+ .driver_data = (void *)400000,
},
{}
};
@@ -160,8 +159,7 @@ static void intel_quark_unregister_i2c_clk(struct device *dev)
static int intel_quark_i2c_setup(struct pci_dev *pdev, struct mfd_cell *cell)
{
- const char *board_name = dmi_get_system_info(DMI_BOARD_NAME);
- const struct i2c_mode_info *info;
+ const struct dmi_system_id *dmi_id;
struct dw_i2c_platform_data *pdata;
struct resource *res = (struct resource *)cell->resources;
struct device *dev = &pdev->dev;
@@ -181,14 +179,9 @@ static int intel_quark_i2c_setup(struct pci_dev *pdev, struct mfd_cell *cell)
/* Normal mode by default */
pdata->i2c_scl_freq = 100000;
- if (board_name) {
- for (info = platform_i2c_mode_info; info->name; info++) {
- if (!strcmp(board_name, info->name)) {
- pdata->i2c_scl_freq = info->i2c_scl_freq;
- break;
- }
- }
- }
+ dmi_id = dmi_first_match(dmi_platform_info);
+ if (dmi_id)
+ pdata->i2c_scl_freq = (uintptr_t)dmi_id->driver_data;
cell->platform_data = pdata;
cell->pdata_size = sizeof(*pdata);
--
2.12.0
[toc] | [next] | [standalone]
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Date | 2017-05-22 19:20 +0200 |
| Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency |
| Message-ID | <tJZ9U-8vX-3@gated-at.bofh.it> |
| In reply to | #1646730 |
On 2017-05-22 19:12, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >> Avoids reimplementation of DMI matching in intel_quark_i2c_setup. > > What's wrong with current approach? I suppose this will make sense > when we will have an issue / impediment. Right now it looks like > over-engineering. > > (Yes, I know what I said to you about this earlier, OTOH see above) > It allows matching on additional DMI tags without additional code - patch 2 depends on it. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-05-22 19:30 +0200 |
| Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency |
| Message-ID | <tJZjA-7i-5@gated-at.bofh.it> |
| In reply to | #1647201 |
On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > On 2017-05-22 19:20, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>> On 2017-05-22 19:12, Andy Shevchenko wrote: >>>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>>>> Avoids reimplementation of DMI matching in intel_quark_i2c_setup. >>>> >>>> What's wrong with current approach? I suppose this will make sense >>>> when we will have an issue / impediment. Right now it looks like >>>> over-engineering. >>>> >>>> (Yes, I know what I said to you about this earlier, OTOH see above) >>>> >>> >>> It allows matching on additional DMI tags without additional code - >>> patch 2 depends on it. >> >> And since there is no difference to the frequency the name is enough. >> So, I wouldn't go with this series as is. See above. > > Nope: Just like for the stmmac, we need to include the asset tags to > avoid matching variations of the devices which may carry the same board > name. While I will try to avoid that this happens, we are better safe > than sorry here. Do we have an issue right now? Yes / No -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-05-22 19:40 +0200 |
| Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency |
| Message-ID | <tJZtg-ao-5@gated-at.bofh.it> |
| In reply to | #1647207 |
On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > On 2017-05-22 19:26, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>> On 2017-05-22 19:20, Andy Shevchenko wrote: >>>> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>>>> On 2017-05-22 19:12, Andy Shevchenko wrote: >>>>>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>>> And since there is no difference to the frequency the name is enough. >>>> So, I wouldn't go with this series as is. See above. >>> >>> Nope: Just like for the stmmac, we need to include the asset tags to >>> avoid matching variations of the devices which may carry the same board >>> name. While I will try to avoid that this happens, we are better safe >>> than sorry here. >> >> Do we have an issue right now? >> Yes / No > > Andy, we are trying to design a robust upstream driver here, no ad-hoc > BSP that will not survive the hardware anyway. You didn't answer my question... I do not see a good point to solve the issue that might happen in the future. -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Date | 2017-05-22 19:40 +0200 |
| Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency |
| Message-ID | <tJZtg-ao-15@gated-at.bofh.it> |
| In reply to | #1647212 |
On 2017-05-22 19:36, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >> On 2017-05-22 19:26, Andy Shevchenko wrote: >>> On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>>> On 2017-05-22 19:20, Andy Shevchenko wrote: >>>>> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>>>>> On 2017-05-22 19:12, Andy Shevchenko wrote: >>>>>>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > >>>>> And since there is no difference to the frequency the name is enough. >>>>> So, I wouldn't go with this series as is. See above. >>>> >>>> Nope: Just like for the stmmac, we need to include the asset tags to >>>> avoid matching variations of the devices which may carry the same board >>>> name. While I will try to avoid that this happens, we are better safe >>>> than sorry here. >>> >>> Do we have an issue right now? >>> Yes / No >> >> Andy, we are trying to design a robust upstream driver here, no ad-hoc >> BSP that will not survive the hardware anyway. > > You didn't answer my question... > > I do not see a good point to solve the issue that might happen in the future. > While I do - that's why your question is misleading. Then let's leave the decision up to the maintainer. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-05-22 19:50 +0200 |
| Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency |
| Message-ID | <tJZCW-dH-5@gated-at.bofh.it> |
| In reply to | #1647216 |
On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > On 2017-05-22 19:36, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>> On 2017-05-22 19:26, Andy Shevchenko wrote: >>>> On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>>>> On 2017-05-22 19:20, Andy Shevchenko wrote: >>>>>> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>>>>>> On 2017-05-22 19:12, Andy Shevchenko wrote: >>>>>>>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>>>>> And since there is no difference to the frequency the name is enough. >>>>>> So, I wouldn't go with this series as is. See above. >>>>> >>>>> Nope: Just like for the stmmac, we need to include the asset tags to >>>>> avoid matching variations of the devices which may carry the same board >>>>> name. While I will try to avoid that this happens, we are better safe >>>>> than sorry here. >>>> >>>> Do we have an issue right now? >>>> Yes / No >>> >>> Andy, we are trying to design a robust upstream driver here, no ad-hoc >>> BSP that will not survive the hardware anyway. >> >> You didn't answer my question... >> >> I do not see a good point to solve the issue that might happen in the future. >> > > While I do - that's why your question is misleading. > > Then let's leave the decision up to the maintainer. Lee, just for your convenience I'm repeating myself here: I do not like this series at all since it tries to solve non-existing issue in over-engineering way. If you on opposite side I will be happy to help reviewing it. -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2017-05-22 20:30 +0200 |
| Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency |
| Message-ID | <tK0fE-HF-15@gated-at.bofh.it> |
| In reply to | #1647219 |
On Mon, 22 May 2017, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > > On 2017-05-22 19:36, Andy Shevchenko wrote: > >> On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > >>> On 2017-05-22 19:26, Andy Shevchenko wrote: > >>>> On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > >>>>> On 2017-05-22 19:20, Andy Shevchenko wrote: > >>>>>> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > >>>>>>> On 2017-05-22 19:12, Andy Shevchenko wrote: > >>>>>>>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > > >>>>>> And since there is no difference to the frequency the name is enough. > >>>>>> So, I wouldn't go with this series as is. See above. > >>>>> > >>>>> Nope: Just like for the stmmac, we need to include the asset tags to > >>>>> avoid matching variations of the devices which may carry the same board > >>>>> name. While I will try to avoid that this happens, we are better safe > >>>>> than sorry here. > >>>> > >>>> Do we have an issue right now? > >>>> Yes / No > >>> > >>> Andy, we are trying to design a robust upstream driver here, no ad-hoc > >>> BSP that will not survive the hardware anyway. > >> > >> You didn't answer my question... > >> > >> I do not see a good point to solve the issue that might happen in the future. > >> > > > > While I do - that's why your question is misleading. > > > > Then let's leave the decision up to the maintainer. > > Lee, just for your convenience I'm repeating myself here: > > I do not like this series at all since it tries to solve non-existing > issue in over-engineering way. > > If you on opposite side I will be happy to help reviewing it. New code looks cleaner and appears to use an already defined API. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-05-22 20:40 +0200 |
| Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency |
| Message-ID | <tK0pk-KA-37@gated-at.bofh.it> |
| In reply to | #1647248 |
On Mon, May 22, 2017 at 9:23 PM, Lee Jones <lee.jones@linaro.org> wrote: > On Mon, 22 May 2017, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >> > On 2017-05-22 19:36, Andy Shevchenko wrote: >> > Then let's leave the decision up to the maintainer. >> >> Lee, just for your convenience I'm repeating myself here: >> >> I do not like this series at all since it tries to solve non-existing >> issue in over-engineering way. >> >> If you on opposite side I will be happy to help reviewing it. > > New code looks cleaner and appears to use an already defined API. Got your point. Jan, care to resend (an updated?) version? -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Date | 2017-05-22 20:50 +0200 |
| Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency |
| Message-ID | <tK0yZ-NW-13@gated-at.bofh.it> |
| In reply to | #1647259 |
On 2017-05-22 20:37, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 9:23 PM, Lee Jones <lee.jones@linaro.org> wrote: >> On Mon, 22 May 2017, Andy Shevchenko wrote: >>> On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>>> On 2017-05-22 19:36, Andy Shevchenko wrote: > >>>> Then let's leave the decision up to the maintainer. >>> >>> Lee, just for your convenience I'm repeating myself here: >>> >>> I do not like this series at all since it tries to solve non-existing >>> issue in over-engineering way. >>> >>> If you on opposite side I will be happy to help reviewing it. >> >> New code looks cleaner and appears to use an already defined API. > > Got your point. > Jan, care to resend (an updated?) version? > Updated in which regard? The one for stmmac is broken, this one should be fine. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-05-22 21:40 +0200 |
| Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency |
| Message-ID | <tK1ln-1kI-3@gated-at.bofh.it> |
| In reply to | #1647261 |
On Mon, May 22, 2017 at 9:47 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > On 2017-05-22 20:37, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 9:23 PM, Lee Jones <lee.jones@linaro.org> wrote: >>> On Mon, 22 May 2017, Andy Shevchenko wrote: >>>> On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >> Got your point. >> Jan, care to resend (an updated?) version? > Updated in which regard? The one for stmmac is broken, this one should > be fine. Can you just resend then, please? I have been out a while and now I have a pile of mails, it would be slightly easy for me to go through a fresh series. -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Date | 2017-05-22 19:40 +0200 |
| Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency |
| Message-ID | <tJZtg-ao-7@gated-at.bofh.it> |
| In reply to | #1647207 |
On 2017-05-22 19:26, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >> On 2017-05-22 19:20, Andy Shevchenko wrote: >>> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>>> On 2017-05-22 19:12, Andy Shevchenko wrote: >>>>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>>>>> Avoids reimplementation of DMI matching in intel_quark_i2c_setup. >>>>> >>>>> What's wrong with current approach? I suppose this will make sense >>>>> when we will have an issue / impediment. Right now it looks like >>>>> over-engineering. >>>>> >>>>> (Yes, I know what I said to you about this earlier, OTOH see above) >>>>> >>>> >>>> It allows matching on additional DMI tags without additional code - >>>> patch 2 depends on it. >>> >>> And since there is no difference to the frequency the name is enough. >>> So, I wouldn't go with this series as is. See above. >> >> Nope: Just like for the stmmac, we need to include the asset tags to >> avoid matching variations of the devices which may carry the same board >> name. While I will try to avoid that this happens, we are better safe >> than sorry here. > > Do we have an issue right now? > Yes / No Andy, we are trying to design a robust upstream driver here, no ad-hoc BSP that will not survive the hardware anyway. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux
[toc] | [prev] | [next] | [standalone]
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Date | 2017-05-22 19:30 +0200 |
| Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency |
| Message-ID | <tJZjA-7i-9@gated-at.bofh.it> |
| In reply to | #1647201 |
On 2017-05-22 19:20, Andy Shevchenko wrote: > On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >> On 2017-05-22 19:12, Andy Shevchenko wrote: >>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>>> Avoids reimplementation of DMI matching in intel_quark_i2c_setup. >>> >>> What's wrong with current approach? I suppose this will make sense >>> when we will have an issue / impediment. Right now it looks like >>> over-engineering. >>> >>> (Yes, I know what I said to you about this earlier, OTOH see above) >>> >> >> It allows matching on additional DMI tags without additional code - >> patch 2 depends on it. > > And since there is no difference to the frequency the name is enough. > So, I wouldn't go with this series as is. See above. Nope: Just like for the stmmac, we need to include the asset tags to avoid matching variations of the devices which may carry the same board name. While I will try to avoid that this happens, we are better safe than sorry here. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-05-22 19:30 +0200 |
| Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency |
| Message-ID | <tJZjA-7i-7@gated-at.bofh.it> |
| In reply to | #1647201 |
On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > On 2017-05-22 19:12, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>> Avoids reimplementation of DMI matching in intel_quark_i2c_setup. >> >> What's wrong with current approach? I suppose this will make sense >> when we will have an issue / impediment. Right now it looks like >> over-engineering. >> >> (Yes, I know what I said to you about this earlier, OTOH see above) >> > > It allows matching on additional DMI tags without additional code - > patch 2 depends on it. And since there is no difference to the frequency the name is enough. So, I wouldn't go with this series as is. See above. -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-05-22 19:20 +0200 |
| Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency |
| Message-ID | <tJZ9U-8vX-5@gated-at.bofh.it> |
| In reply to | #1646730 |
On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > Avoids reimplementation of DMI matching in intel_quark_i2c_setup. What's wrong with current approach? I suppose this will make sense when we will have an issue / impediment. Right now it looks like over-engineering. (Yes, I know what I said to you about this earlier, OTOH see above) -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web