Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1647259

Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

From Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
Date 2017-05-22 20:40 +0200
Message-ID <tK0pk-KA-37@gated-at.bofh.it> (permalink)
References (6 earlier) <tJZtg-ao-7@gated-at.bofh.it> <tJZtg-ao-5@gated-at.bofh.it> <tJZtg-ao-15@gated-at.bofh.it> <tJZCW-dH-5@gated-at.bofh.it> <tK0fE-HF-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, May 22, 2017 at 9:23 PM, Lee Jones <lee.jones@linaro.org> wrote:
> On Mon, 22 May 2017, Andy Shevchenko wrote:
>> On Mon, May 22, 2017 at 8:38 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> > On 2017-05-22 19:36, Andy Shevchenko wrote:

>> > Then let's leave the decision up to the maintainer.
>>
>> Lee, just for your convenience I'm repeating myself here:
>>
>> I do not like this series at all since it tries to solve non-existing
>> issue in over-engineering way.
>>
>> If you on opposite side I will be happy to help reviewing it.
>
> New code looks cleaner and appears to use an already defined API.

Got your point.
Jan, care to resend  (an updated?) version?

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 13:00 +0200
  Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:20 +0200
    Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:30 +0200
      Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:40 +0200
        Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:40 +0200
          Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:50 +0200
            Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id  table for retrieving frequency Lee Jones <lee.jones@linaro.org> - 2017-05-22 20:30 +0200
              Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 20:40 +0200
                Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 20:50 +0200
                Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 21:40 +0200
      Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:40 +0200
    Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:30 +0200
    Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:30 +0200
  Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:20 +0200

csiph-web