Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1647210
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency |
| Date | 2017-05-22 19:30 +0200 |
| Message-ID | <tJZjA-7i-7@gated-at.bofh.it> (permalink) |
| References | <tJTe9-4Fe-5@gated-at.bofh.it> <tJTe9-4Fe-3@gated-at.bofh.it> <tJZ9U-8vX-5@gated-at.bofh.it> <tJZ9U-8vX-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > On 2017-05-22 19:12, Andy Shevchenko wrote: >> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: >>> Avoids reimplementation of DMI matching in intel_quark_i2c_setup. >> >> What's wrong with current approach? I suppose this will make sense >> when we will have an issue / impediment. Right now it looks like >> over-engineering. >> >> (Yes, I know what I said to you about this earlier, OTOH see above) >> > > It allows matching on additional DMI tags without additional code - > patch 2 depends on it. And since there is no difference to the frequency the name is enough. So, I wouldn't go with this series as is. See above. -- With Best Regards, Andy Shevchenko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 13:00 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:20 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:30 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:40 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:40 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:50 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Lee Jones <lee.jones@linaro.org> - 2017-05-22 20:30 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 20:40 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 20:50 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 21:40 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:40 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:30 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:30 +0200
Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:20 +0200
csiph-web