Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
Date	2017-05-22 19:40 +0200
Message-ID	<tJZtg-ao-5@gated-at.bofh.it> (permalink)
References	(3 earlier) <tJZ9U-8vX-3@gated-at.bofh.it> <tJZjA-7i-7@gated-at.bofh.it> <tJZjA-7i-9@gated-at.bofh.it> <tJZjA-7i-5@gated-at.bofh.it> <tJZtg-ao-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 22, 2017 at 8:34 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2017-05-22 19:26, Andy Shevchenko wrote:
>> On Mon, May 22, 2017 at 8:25 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>> On 2017-05-22 19:20, Andy Shevchenko wrote:
>>>> On Mon, May 22, 2017 at 8:18 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>>>> On 2017-05-22 19:12, Andy Shevchenko wrote:
>>>>>> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:

>>>> And since there is no difference to the frequency the name is enough.
>>>> So, I wouldn't go with this series as is. See above.
>>>
>>> Nope: Just like for the stmmac, we need to include the asset tags to
>>> avoid matching variations of the devices which may carry the same board
>>> name. While I will try to avoid that this happens, we are better safe
>>> than sorry here.
>>
>> Do we have an issue right now?
>> Yes / No
>
> Andy, we are trying to design a robust upstream driver here, no ad-hoc
> BSP that will not survive the hardware anyway.

You didn't answer my question...

I do not see a good point to solve the issue that might happen in the future.

-- 
With Best Regards,
Andy Shevchenko

Thread

[PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 13:00 +0200
  Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:20 +0200
    Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:30 +0200
      Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:40 +0200
        Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:40 +0200
          Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:50 +0200
            Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id  table for retrieving frequency Lee Jones <lee.jones@linaro.org> - 2017-05-22 20:30 +0200
              Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 20:40 +0200
                Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 20:50 +0200
                Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 21:40 +0200
      Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:40 +0200
    Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 19:30 +0200
    Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:30 +0200
  Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table  for retrieving frequency Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 19:20 +0200

csiph-web