Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Randy Dunlap <rdunlap@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m
Date	Tue, 26 Sep 2017 00:40:01 +0200
Message-ID	<utKcF-4eR-1@gated-at.bofh.it> (permalink)
References	<use5c-4l9-25@gated-at.bofh.it> <ussrw-4nN-13@gated-at.bofh.it> <usHJT-58r-1@gated-at.bofh.it> <utEgW-iV-19@gated-at.bofh.it> <utFmG-11y-21@gated-at.bofh.it> <utHeN-2eS-3@gated-at.bofh.it> <utHeN-2eS-5@gated-at.bofh.it> <utHot-2k6-5@gated-at.bofh.it> <utHya-2oD-7@gated-at.bofh.it> <utHHQ-2sG-25@gated-at.bofh.it> <utIXg-3we-23@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=b+TZjxHRUxlOMm6VHlTJhBf+oAEHiHhhc/J2AEUogD0=; b=W5dU0sLIS2Q2zlwfFhXfWznV73 YuzT1hlBHqkzFZ9DesUGvOdQ9fmdJr4O+JUbAqrkDbArRdfjFdJOmAKEuTnxH+n1K6YIkvaKKIQFW WxxfTXgwCYlK5t3XUX5st7QIz//74aSaNBDKcY+aQ5U2eFc8FMBr4owC+4Scpg5WXMBggv9AjqduC ZQkC2jvjXIL1+3ofMsq2SJ+8WiG7kVTscQgxGlS6msBW6PeeRE/3LyLoRLYBhlQBU2/A8itdSgN/8 zOa16YJBylbcF1+TToNvUdQZgKqedhSRb3OxDf0v2C4zx/kRAqiE32zEZ2x9nzCJYp9L7siAbO/gi qxe/+g/Q==;
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Language	en-US
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	26
Organization	linux.* mail to news gateway
X-Original-Cc	Mark Brown <broonie@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>, linux-spi <linux-spi@vger.kernel.org>, Baolin Wang <Baolin.Wang@spreadtrum.com>
X-Original-Date	Mon, 25 Sep 2017 15:32:56 -0700
X-Original-Message-ID	<faf455ad-b7ef-beac-ac6d-4822f350cd71@infradead.org>
X-Original-References	<ed5b8ca2-b853-755d-2801-57cc0b626508@infradead.org> <20170922092621.uq2xsvxangeetewi@sirena.org.uk> <9dc8b064-8a6c-98d2-4ade-088cbfd56fb1@infradead.org> <20170925161221.v23dpeljin5kakhz@sirena.org.uk> <449abd0e-8d8b-86e9-2b7a-65c27ab3171b@infradead.org> <CAMuHMdXwv7s-uBM2J1Rf5fw+2=N_VcPxCYHartgUxb56yrR23A@mail.gmail.com> <20170925192256.bmrm6gmb4idvomxb@sirena.org.uk> <156431d9-a518-53e7-17d9-bb1ee0f637bb@infradead.org> <20170925194417.bjkw5ar6s57bkbdt@sirena.org.uk> <c0c60c5e-d06f-b246-fb63-3eb507c62449@infradead.org> <20170925211154.j23g4b2xmu4f3cxc@sirena.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1739320

Show key headers only | View raw

On 09/25/17 14:11, Mark Brown wrote:
> On Mon, Sep 25, 2017 at 12:53:20PM -0700, Randy Dunlap wrote:
>> On 09/25/17 12:44, Mark Brown wrote:
> 
>>> That would then get in the way of build test coverage.  
> 
>> I don't agree, but whatever. I give up.
> 
> OK.  Just as a general thing it's really important that dependency
> changes be thought through and express what the constraints are in ways
> that reflect what's actually going on and what's useful for users, it
> seems to be a frequent problem and it does get in the way.

Yes, it's a frequent problem that drivers do not build due to some kconfig
dependency issue(s).

I would prefer to see the driver maintainer(s) fix build errors themselves,
but they are not always aware of the idiosyncrasies of kconfig.

I think that people often submit drivers (or driver changes) after building
it in one (working) configuration only, without regard for the other possible
combinations.

-- 
~Randy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-21 20:10 +0200
  Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-22 11:30 +0200
    Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-23 03:50 +0200
      Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 18:20 +0200
        Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-25 19:30 +0200
          Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 20:50 +0200
          Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Geert Uytterhoeven <geert@linux-m68k.org> - 2017-09-25 21:30 +0200
            Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 21:30 +0200
              Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-25 21:40 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 21:50 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-25 22:00 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 23:20 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-26 00:40 +0200

csiph-web