Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m

From	Randy Dunlap <rdunlap@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m
Date	2017-09-26 00:40 +0200
Message-ID	<utKcF-4eR-1@gated-at.bofh.it> (permalink)
References	(6 earlier) <utHeN-2eS-5@gated-at.bofh.it> <utHot-2k6-5@gated-at.bofh.it> <utHya-2oD-7@gated-at.bofh.it> <utHHQ-2sG-25@gated-at.bofh.it> <utIXg-3we-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/25/17 14:11, Mark Brown wrote:
> On Mon, Sep 25, 2017 at 12:53:20PM -0700, Randy Dunlap wrote:
>> On 09/25/17 12:44, Mark Brown wrote:
> 
>>> That would then get in the way of build test coverage.  
> 
>> I don't agree, but whatever. I give up.
> 
> OK.  Just as a general thing it's really important that dependency
> changes be thought through and express what the constraints are in ways
> that reflect what's actually going on and what's useful for users, it
> seems to be a frequent problem and it does get in the way.

Yes, it's a frequent problem that drivers do not build due to some kconfig
dependency issue(s).

I would prefer to see the driver maintainer(s) fix build errors themselves,
but they are not always aware of the idiosyncrasies of kconfig.

I think that people often submit drivers (or driver changes) after building
it in one (working) configuration only, without regard for the other possible
combinations.

-- 
~Randy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-21 20:10 +0200
  Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-22 11:30 +0200
    Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-23 03:50 +0200
      Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 18:20 +0200
        Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-25 19:30 +0200
          Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 20:50 +0200
          Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Geert Uytterhoeven <geert@linux-m68k.org> - 2017-09-25 21:30 +0200
            Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 21:30 +0200
              Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-25 21:40 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 21:50 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-25 22:00 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 23:20 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-26 00:40 +0200

csiph-web