Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1739240

Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m

From Randy Dunlap <rdunlap@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m
Date 2017-09-25 21:40 +0200
Message-ID <utHot-2k6-5@gated-at.bofh.it> (permalink)
References (2 earlier) <usHJT-58r-1@gated-at.bofh.it> <utEgW-iV-19@gated-at.bofh.it> <utFmG-11y-21@gated-at.bofh.it> <utHeN-2eS-3@gated-at.bofh.it> <utHeN-2eS-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 09/25/17 12:22, Mark Brown wrote:
> On Mon, Sep 25, 2017 at 09:20:31PM +0200, Geert Uytterhoeven wrote:
> 
>> The issue is builtin drivers that depend on a modular API.  The clean way
>> is to separate API and implementation, so the API can be builtin, and the
>> implementation can be modular.
>> Hence the API should provide stubs that call into function pointers, to be
>> registered by the module providing the implementation.
> 
> In this case the problem is even more basic in that the driver does
> actually depend on having hwspinlocks for any production use.
> 

so just add:
	depends on HWSPINLOCK

Is that satisfactory to you?

-- 
~Randy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-21 20:10 +0200
  Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-22 11:30 +0200
    Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-23 03:50 +0200
      Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 18:20 +0200
        Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-25 19:30 +0200
          Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 20:50 +0200
          Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Geert Uytterhoeven <geert@linux-m68k.org> - 2017-09-25 21:30 +0200
            Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 21:30 +0200
              Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-25 21:40 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 21:50 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-25 22:00 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 23:20 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-26 00:40 +0200

csiph-web