Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1736986

[PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m

Show all headers | View raw

From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors when CONFIG_HWSPINLOCK=m and SPI_SPRD_ADI=y.
That combination is not allowed.

drivers/spi/spi-sprd-adi.o: In function `sprd_adi_remove':
spi-sprd-adi.c:(.text+0x13): undefined reference to `hwspin_lock_free'
drivers/spi/spi-sprd-adi.o: In function `sprd_adi_probe':
spi-sprd-adi.c:(.text+0xf5): undefined reference to `of_hwspin_lock_get_id'
spi-sprd-adi.c:(.text+0x107): undefined reference to `hwspin_lock_request_specific'
spi-sprd-adi.c:(.text+0x22e): undefined reference to `hwspin_lock_free'
drivers/spi/spi-sprd-adi.o: In function `sprd_adi_transfer_one':
spi-sprd-adi.c:(.text+0x2eb): undefined reference to `__hwspin_lock_timeout'
spi-sprd-adi.c:(.text+0x349): undefined reference to `__hwspin_unlock'
spi-sprd-adi.c:(.text+0x389): undefined reference to `__hwspin_lock_timeout'
spi-sprd-adi.c:(.text+0x3ee): undefined reference to `__hwspin_unlock'

v2: allow build with or without HWSPINLOCK, but restrict to =m
if HWSPINLOCK=m.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Baolin Wang <Baolin.Wang@spreadtrum.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org
---
 drivers/spi/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20170921.orig/drivers/spi/Kconfig
+++ linux-next-20170921/drivers/spi/Kconfig
@@ -625,6 +625,7 @@ config SPI_SIRF
 config SPI_SPRD_ADI
 	tristate "Spreadtrum ADI controller"
 	depends on ARCH_SPRD || COMPILE_TEST
+	depends on HWSPINLOCK || HWSPINLOCK=n
 	help
 	  ADI driver based on SPI for Spreadtrum SoCs.
 

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-21 20:10 +0200
  Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-22 11:30 +0200
    Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-23 03:50 +0200
      Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 18:20 +0200
        Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-25 19:30 +0200
          Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 20:50 +0200
          Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Geert Uytterhoeven <geert@linux-m68k.org> - 2017-09-25 21:30 +0200
            Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 21:30 +0200
              Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-25 21:40 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 21:50 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-25 22:00 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Mark Brown <broonie@kernel.org> - 2017-09-25 23:20 +0200
                Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when  SPI_SPRD_ADI=y and HWSPINLOCK=m Randy Dunlap <rdunlap@infradead.org> - 2017-09-26 00:40 +0200

csiph-web