Re: [PATCH v3 net-next] staging: irda: fix init level for irda core

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 net-next] staging: irda: fix init level for irda core
Date	2017-08-30 19:20 +0200
Message-ID	<ukeOK-2Hq-7@gated-at.bofh.it> (permalink)
References	<ujSEy-5y1-21@gated-at.bofh.it> <ujSOd-5C2-7@gated-at.bofh.it> <uk9cm-7C1-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Greg KH <gregkh@linuxfoundation.org>
Date: Wed, 30 Aug 2017 13:16:49 +0200

> When moving the IRDA code out of net/ into drivers/staging/irda/net, the
> link order changes when IRDA is built into the kernel.  That causes a
> kernel crash at boot time as netfilter isn't initialized yet.
> 
> To fix this, move the init call level of the irda core to be
> device_initcall() as the link order keeps this being initialized at the
> correct time.
> 
> Reported-by: kernel test robot <fengguang.wu@intel.com>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> 
> v3 - just change the initcall level, works so much simpler, thanks to
>      DaveM for the idea.
> v2 - don't force irda to be a module, make the Makefiles put irda back
>      where it was before in the link order.

Applied, thanks for following up on this Greg.

Thread

[PATCH net-next] staging: irda: update MAINTAINERS Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-29 09:10 +0200
  [PATCH net-next] staging: irda: force to be a kernel module Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-29 11:20 +0200
    Re: [PATCH net-next] staging: irda: force to be a kernel module David Miller <davem@davemloft.net> - 2017-08-29 18:40 +0200
      Re: [PATCH net-next] staging: irda: force to be a kernel module Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 19:30 +0200
        Re: [PATCH net-next] staging: irda: force to be a kernel module Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 19:40 +0200
          Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into  the kernel David Miller <davem@davemloft.net> - 2017-08-29 19:50 +0200
            Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into  the kernel Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 21:10 +0200
          [PATCH v2 net-next] irda: fix link order if IRDA is built into the  kernel Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 19:50 +0200
            [PATCH v3 net-next] staging: irda: fix init level for irda core Greg KH <gregkh@linuxfoundation.org> - 2017-08-30 13:20 +0200
              Re: [PATCH v3 net-next] staging: irda: fix init level for irda core David Miller <davem@davemloft.net> - 2017-08-30 19:20 +0200
        Re: [PATCH net-next] staging: irda: force to be a kernel module David Miller <davem@davemloft.net> - 2017-08-29 19:50 +0200
  Re: [PATCH net-next] staging: irda: update MAINTAINERS David Miller <davem@davemloft.net> - 2017-08-29 18:40 +0200

csiph-web