Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into the kernel

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into the kernel
Date	2017-08-29 21:10 +0200
Message-ID	<ujU3D-6AB-11@gated-at.bofh.it> (permalink)
References	<ujSuR-5uV-11@gated-at.bofh.it> <ujSEy-5y1-21@gated-at.bofh.it> <ujSOd-5C2-7@gated-at.bofh.it> <ujSOd-5C2-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 29, 2017 at 10:49:45AM -0700, David Miller wrote:
> From: Greg KH <gregkh@linuxfoundation.org>
> Date: Tue, 29 Aug 2017 19:46:22 +0200
> 
> > When moving the IRDA code out of net/ into drivers/staging/irda/net, the
> > link order changes when IRDA is built into the kernel.  That causes a
> > kernel crash at boot time as netfilter isn't initialized yet.
> > 
> > To fix this, build and link the irda networking code in the same exact
> > order that it was previously before the move.
> > 
> > Reported-by: kernel test robot <fengguang.wu@intel.com>
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
> 
> Greg, just change the initializer in IRDA so that it will run
> after subsys_init() when built statically.
> 
> IRDA is definitely not the first pontentially statically built
> thing that needs netlink up and available.

Ok, will do that tomorrow and test it and send you the patch.

thanks,

greg k-h

Thread

[PATCH net-next] staging: irda: update MAINTAINERS Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-29 09:10 +0200
  [PATCH net-next] staging: irda: force to be a kernel module Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-29 11:20 +0200
    Re: [PATCH net-next] staging: irda: force to be a kernel module David Miller <davem@davemloft.net> - 2017-08-29 18:40 +0200
      Re: [PATCH net-next] staging: irda: force to be a kernel module Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 19:30 +0200
        Re: [PATCH net-next] staging: irda: force to be a kernel module Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 19:40 +0200
          Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into  the kernel David Miller <davem@davemloft.net> - 2017-08-29 19:50 +0200
            Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into  the kernel Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 21:10 +0200
          [PATCH v2 net-next] irda: fix link order if IRDA is built into the  kernel Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 19:50 +0200
            [PATCH v3 net-next] staging: irda: fix init level for irda core Greg KH <gregkh@linuxfoundation.org> - 2017-08-30 13:20 +0200
              Re: [PATCH v3 net-next] staging: irda: fix init level for irda core David Miller <davem@davemloft.net> - 2017-08-30 19:20 +0200
        Re: [PATCH net-next] staging: irda: force to be a kernel module David Miller <davem@davemloft.net> - 2017-08-29 19:50 +0200
  Re: [PATCH net-next] staging: irda: update MAINTAINERS David Miller <davem@davemloft.net> - 2017-08-29 18:40 +0200

csiph-web