Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1722649
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next] staging: irda: force to be a kernel module |
| Date | 2017-08-29 19:50 +0200 |
| Message-ID | <ujSOe-5C2-11@gated-at.bofh.it> (permalink) |
| References | <ujKQG-L5-17@gated-at.bofh.it> <ujRIu-4WZ-19@gated-at.bofh.it> <ujSuR-5uV-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Greg KH <gregkh@linuxfoundation.org> Date: Tue, 29 Aug 2017 19:26:08 +0200 > On Tue, Aug 29, 2017 at 09:35:07AM -0700, David Miller wrote: >> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Date: Tue, 29 Aug 2017 11:14:17 +0200 >> >> > Now that the IRDA networking code has moved into drivers/staging/, the >> > link order is changed for when it is initialized if built into the >> > system. This can cause a crash when initializing as the netfilter core >> > hasn't been initialized yet. >> > >> > So force the IRDA code to be built as a module, preventing the crash. >> > >> > Reported-by: kernel test robot <fengguang.wu@intel.com> >> > Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org >> >> I don't think this is reasonable. >> >> IRDA being built in was broken by moving it to staging, so it's a >> regression and we should find a way to fix it. > > Hm, this is due to netlink coming before irda in the link order before > this patch series. I can't change the link order to put all of net/ > before drivers/, which would solve this, and I don't think I can put: > obj-$(CONFIG_IRDA) += ../../drivers/staging/irda/net/ > in a networking Makefile, can I? Does "../" even work in a Makefile > like that? > > Any other thoughts? Change the initialization type in IRDA from subsys_init() to ... something else? Amazing!
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next] staging: irda: update MAINTAINERS Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-29 09:10 +0200
[PATCH net-next] staging: irda: force to be a kernel module Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-29 11:20 +0200
Re: [PATCH net-next] staging: irda: force to be a kernel module David Miller <davem@davemloft.net> - 2017-08-29 18:40 +0200
Re: [PATCH net-next] staging: irda: force to be a kernel module Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 19:30 +0200
Re: [PATCH net-next] staging: irda: force to be a kernel module Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 19:40 +0200
Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into the kernel David Miller <davem@davemloft.net> - 2017-08-29 19:50 +0200
Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into the kernel Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 21:10 +0200
[PATCH v2 net-next] irda: fix link order if IRDA is built into the kernel Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 19:50 +0200
[PATCH v3 net-next] staging: irda: fix init level for irda core Greg KH <gregkh@linuxfoundation.org> - 2017-08-30 13:20 +0200
Re: [PATCH v3 net-next] staging: irda: fix init level for irda core David Miller <davem@davemloft.net> - 2017-08-30 19:20 +0200
Re: [PATCH net-next] staging: irda: force to be a kernel module David Miller <davem@davemloft.net> - 2017-08-29 19:50 +0200
Re: [PATCH net-next] staging: irda: update MAINTAINERS David Miller <davem@davemloft.net> - 2017-08-29 18:40 +0200
csiph-web