Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1722606

Re: [PATCH net-next] staging: irda: force to be a kernel module

Show all headers | View raw

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Tue, 29 Aug 2017 11:14:17 +0200

> Now that the IRDA networking code has moved into drivers/staging/, the
> link order is changed for when it is initialized if built into the
> system.  This can cause a crash when initializing as the netfilter core
> hasn't been initialized yet.
> 
> So force the IRDA code to be built as a module, preventing the crash.
> 
> Reported-by: kernel test robot <fengguang.wu@intel.com>
> Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org

I don't think this is reasonable.

IRDA being built in was broken by moving it to staging, so it's a
regression and we should find a way to fix it.

It's one thing if IRDA on it's own has deteriorated and broken in some
ways over time due to lack of maintainence, it's another to knowingly
do something to it that causes a regression which is what happened
here.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] staging: irda: update MAINTAINERS Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-29 09:10 +0200
  [PATCH net-next] staging: irda: force to be a kernel module Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-29 11:20 +0200
    Re: [PATCH net-next] staging: irda: force to be a kernel module David Miller <davem@davemloft.net> - 2017-08-29 18:40 +0200
      Re: [PATCH net-next] staging: irda: force to be a kernel module Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 19:30 +0200
        Re: [PATCH net-next] staging: irda: force to be a kernel module Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 19:40 +0200
          Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into  the kernel David Miller <davem@davemloft.net> - 2017-08-29 19:50 +0200
            Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into  the kernel Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 21:10 +0200
          [PATCH v2 net-next] irda: fix link order if IRDA is built into the  kernel Greg KH <gregkh@linuxfoundation.org> - 2017-08-29 19:50 +0200
            [PATCH v3 net-next] staging: irda: fix init level for irda core Greg KH <gregkh@linuxfoundation.org> - 2017-08-30 13:20 +0200
              Re: [PATCH v3 net-next] staging: irda: fix init level for irda core David Miller <davem@davemloft.net> - 2017-08-30 19:20 +0200
        Re: [PATCH net-next] staging: irda: force to be a kernel module David Miller <davem@davemloft.net> - 2017-08-29 19:50 +0200
  Re: [PATCH net-next] staging: irda: update MAINTAINERS David Miller <davem@davemloft.net> - 2017-08-29 18:40 +0200

csiph-web