Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1717300

Re: isofs: One check less in isofs_read_inode() after error detection

From Jan Kara <jack@suse.cz>
Newsgroups linux.kernel
Subject Re: isofs: One check less in isofs_read_inode() after error detection
Date 2017-08-22 12:50 +0200
Message-ID <uheUV-18s-1@gated-at.bofh.it> (permalink)
References <ug6d3-6Hr-3@gated-at.bofh.it> <ug6d3-6Hr-7@gated-at.bofh.it> <ugVIB-5rU-1@gated-at.bofh.it> <ugVIC-5rU-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon 21-08-17 16:18:14, SF Markus Elfring wrote:
> > I agree that
> > 
> > fail:
> >         goto out;
> > 
> > in the original code is awkward and we can get rid of it.
> 
> How would you like to change this place instead?

Just do 'goto out' directly.

								Honza

-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] ISOFS: Adjustments for three function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 09:20 +0200
  [PATCH 3/4] isofs: One check less in isofs_read_inode() after error  detection SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 09:20 +0200
    Re: [PATCH 3/4] isofs: One check less in isofs_read_inode() after  error detection Jan Kara <jack@suse.cz> - 2017-08-21 16:20 +0200
      Re: isofs: One check less in isofs_read_inode() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-21 16:20 +0200
        Re: isofs: One check less in isofs_read_inode() after error detection Jan Kara <jack@suse.cz> - 2017-08-22 12:50 +0200
  [PATCH 4/4] isofs: Delete an unnecessary variable initialisation in  isofs_read_inode() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 09:20 +0200
    Re: [PATCH 4/4] isofs: Delete an unnecessary variable initialisation  in isofs_read_inode() Jan Kara <jack@suse.cz> - 2017-08-21 16:20 +0200

csiph-web