Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1716531
| From | Jan Kara <jack@suse.cz> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/4] isofs: One check less in isofs_read_inode() after error detection |
| Date | 2017-08-21 16:20 +0200 |
| Message-ID | <ugVIB-5rU-1@gated-at.bofh.it> (permalink) |
| References | <ug6d3-6Hr-3@gated-at.bofh.it> <ug6d3-6Hr-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat 19-08-17 09:18:42, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 19 Aug 2017 08:10:40 +0200
>
> * Adjust jump targets.
>
> * Avoid a repeated check for the local variable "bh" after
> a memory allocation failure in this function.
>
> * Delete an initialisation for the local variable "ret"
> which became unnecessary with this refactoring.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
I agree that
fail:
goto out;
in the original code is awkward and we can get rid of it. However renaming
labels is IMO pointless and
> if (bh)
> +release_bh:
> brelse(bh);
> return ret;
is just disgusting.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] ISOFS: Adjustments for three function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 09:20 +0200
[PATCH 3/4] isofs: One check less in isofs_read_inode() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 09:20 +0200
Re: [PATCH 3/4] isofs: One check less in isofs_read_inode() after error detection Jan Kara <jack@suse.cz> - 2017-08-21 16:20 +0200
Re: isofs: One check less in isofs_read_inode() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-21 16:20 +0200
Re: isofs: One check less in isofs_read_inode() after error detection Jan Kara <jack@suse.cz> - 2017-08-22 12:50 +0200
[PATCH 4/4] isofs: Delete an unnecessary variable initialisation in isofs_read_inode() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 09:20 +0200
Re: [PATCH 4/4] isofs: Delete an unnecessary variable initialisation in isofs_read_inode() Jan Kara <jack@suse.cz> - 2017-08-21 16:20 +0200
csiph-web