Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1716539
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: isofs: One check less in isofs_read_inode() after error detection |
| Date | 2017-08-21 16:20 +0200 |
| Message-ID | <ugVIC-5rU-21@gated-at.bofh.it> (permalink) |
| References | <ug6d3-6Hr-3@gated-at.bofh.it> <ug6d3-6Hr-7@gated-at.bofh.it> <ugVIB-5rU-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> I agree that > > fail: > goto out; > > in the original code is awkward and we can get rid of it. How would you like to change this place instead? > However renaming labels is IMO pointless and > >> if (bh) >> +release_bh: >> brelse(bh); >> return ret; > > is just disgusting. I know that it can be occasionally harder to achieve the desired consensus. Regards, Markus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] ISOFS: Adjustments for three function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 09:20 +0200
[PATCH 3/4] isofs: One check less in isofs_read_inode() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 09:20 +0200
Re: [PATCH 3/4] isofs: One check less in isofs_read_inode() after error detection Jan Kara <jack@suse.cz> - 2017-08-21 16:20 +0200
Re: isofs: One check less in isofs_read_inode() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-21 16:20 +0200
Re: isofs: One check less in isofs_read_inode() after error detection Jan Kara <jack@suse.cz> - 2017-08-22 12:50 +0200
[PATCH 4/4] isofs: Delete an unnecessary variable initialisation in isofs_read_inode() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 09:20 +0200
Re: [PATCH 4/4] isofs: Delete an unnecessary variable initialisation in isofs_read_inode() Jan Kara <jack@suse.cz> - 2017-08-21 16:20 +0200
csiph-web