Re: [PATCH 4/4] isofs: Delete an unnecessary variable initialisation in isofs_read_inode()

From	Jan Kara <jack@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] isofs: Delete an unnecessary variable initialisation in isofs_read_inode()
Date	2017-08-21 16:20 +0200
Message-ID	<ugVIC-5rU-13@gated-at.bofh.it> (permalink)
References	<ug6d3-6Hr-3@gated-at.bofh.it> <ug6d3-6Hr-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat 19-08-17 09:19:34, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 19 Aug 2017 08:13:46 +0200
> 
> The local variable "bh" will be set to an appropriate pointer a bit later.
> Thus omit the explicit initialisation at the beginning.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Applied to my tree. Thanks.

								Honza
> ---
>  fs/isofs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
> index f6d6c2ca8723..3a33b3db712a 100644
> --- a/fs/isofs/inode.c
> +++ b/fs/isofs/inode.c
> @@ -1298,7 +1298,7 @@ static int isofs_read_inode(struct inode *inode, int relocated)
>  	unsigned long bufsize = ISOFS_BUFFER_SIZE(inode);
>  	unsigned long block;
>  	int high_sierra = sbi->s_high_sierra;
> -	struct buffer_head *bh = NULL;
> +	struct buffer_head *bh;
>  	struct iso_directory_record *de;
>  	struct iso_directory_record *tmpde = NULL;
>  	unsigned int de_len;
> -- 
> 2.14.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] ISOFS: Adjustments for three function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 09:20 +0200
  [PATCH 3/4] isofs: One check less in isofs_read_inode() after error  detection SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 09:20 +0200
    Re: [PATCH 3/4] isofs: One check less in isofs_read_inode() after  error detection Jan Kara <jack@suse.cz> - 2017-08-21 16:20 +0200
      Re: isofs: One check less in isofs_read_inode() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-21 16:20 +0200
        Re: isofs: One check less in isofs_read_inode() after error detection Jan Kara <jack@suse.cz> - 2017-08-22 12:50 +0200
  [PATCH 4/4] isofs: Delete an unnecessary variable initialisation in  isofs_read_inode() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 09:20 +0200
    Re: [PATCH 4/4] isofs: Delete an unnecessary variable initialisation  in isofs_read_inode() Jan Kara <jack@suse.cz> - 2017-08-21 16:20 +0200

csiph-web