Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1618880

Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support
Date 2017-04-07 17:10 +0200
Message-ID <ttDGp-nA-1@gated-at.bofh.it> (permalink)
References <ttxhD-4AV-7@gated-at.bofh.it> <ttxhE-4AV-37@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Apr 07, 2017 at 10:15:02AM +0200, Juergen Borleis wrote:
> When the LAN9303 device is in MDIO manged mode, all register accesses must
> be done via MDIO.
> 
> Please note: this code is *untested* yet due to the absence of such
> configured hardware. It is based on a patch of Stefan Roese from 2014.

I looked through the code and i don't see anything obviously
wrong. But so long as we get the ABI correct, we can fix everything
else later. And the ABI here is just the device tree binding. And that
is identical to the i2c binding. The properties just go in a different
place in the tree. So please do the *TODO*, you can look at other
examples, e.g. the Marvell binding documentation.

With that done, i will ACK this code.

     Andrew

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCHv2] net: dsa: add SMSC/Microchip LAN9303 three port ethernet switch driver Juergen Borleis <jbe@pengutronix.de> - 2017-04-07 10:20 +0200
  [PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support Juergen Borleis <jbe@pengutronix.de> - 2017-04-07 10:20 +0200
    Re: [PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support Andrew Lunn <andrew@lunn.ch> - 2017-04-07 15:50 +0200
      Re: [PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support Juergen Borleis <jbe@pengutronix.de> - 2017-04-10 10:00 +0200
  [PATCH v2 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Juergen Borleis <jbe@pengutronix.de> - 2017-04-07 10:20 +0200
    Re: [PATCH v2 2/4] net: dsa: add new DSA switch driver for the  SMSC-LAN9303 David Miller <davem@davemloft.net> - 2017-04-07 15:40 +0200
    Re: [PATCH v2 2/4] net: dsa: add new DSA switch driver for the  SMSC-LAN9303 Andrew Lunn <andrew@lunn.ch> - 2017-04-07 16:40 +0200
      Re: [PATCH v2 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Juergen Borleis <jbe@pengutronix.de> - 2017-04-10 09:50 +0200
        Re: [PATCH v2 2/4] net: dsa: add new DSA switch driver for the  SMSC-LAN9303 Andrew Lunn <andrew@lunn.ch> - 2017-04-10 15:30 +0200
  [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support Juergen Borleis <jbe@pengutronix.de> - 2017-04-07 10:20 +0200
    Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support Andrew Lunn <andrew@lunn.ch> - 2017-04-07 16:30 +0200
      Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support David Miller <davem@davemloft.net> - 2017-04-07 16:30 +0200
    Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support Andrew Lunn <andrew@lunn.ch> - 2017-04-07 17:00 +0200
    Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support Andrew Lunn <andrew@lunn.ch> - 2017-04-07 17:10 +0200
  [PATCH v2 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Juergen Borleis <jbe@pengutronix.de> - 2017-04-07 10:20 +0200
    Re: [PATCH v2 1/4] net: dsa: add support for the SMSC-LAN9303  tagging format Andrew Lunn <andrew@lunn.ch> - 2017-04-07 15:10 +0200
      Re: [PATCH v2 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Juergen Borleis <jbe@pengutronix.de> - 2017-04-10 09:20 +0200
        Re: [PATCH v2 1/4] net: dsa: add support for the SMSC-LAN9303  tagging format Andrew Lunn <andrew@lunn.ch> - 2017-04-10 15:20 +0200

csiph-web