Re: [PATCH 1/5] perf annotate: Refactor the code to parse disassemble lines with {l,r}trim()

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] perf annotate: Refactor the code to parse disassemble lines with {l,r}trim()
Date	2017-04-07 17:10 +0200
Message-ID	<ttDGp-nA-7@gated-at.bofh.it> (permalink)
References	<ttD3H-8io-3@gated-at.bofh.it> <ttD3I-8io-29@gated-at.bofh.it> <ttDGp-nA-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Fri, Apr 07, 2017 at 12:01:30PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Apr 07, 2017 at 11:24:17PM +0900, Taeung Song escreveu:
> > @@ -1148,9 +1136,9 @@ static int symbol__parse_objdump_line(struct symbol *sym, struct map *map,
> >  {
> >  	struct annotation *notes = symbol__annotation(sym);
> >  	struct disasm_line *dl;
> > -	char *line = NULL, *parsed_line, *tmp, *tmp2, *c;
> > +	char *line = NULL, *parsed_line, *tmp, *tmp2;
> >  	size_t line_len;
> > -	s64 line_ip, offset = -1;
> > +	s64 line_ip = -1, offset = -1;
> 
> Try to avoid doing these unrelated changes, i.e. moving the setting of
> line_ip to -1 from down below to here.
> 
> It is unrelated to what you're doing here, i.e. using ltrim/rtrim, and
> requires looking at the code to see if this can be done, as I don't know
> if line_ip is set to something else in-between... I am removing this,
> leaving the patch just for rtrim/ltrim.

Ok, please do it yourself, after taking into account the other comment
on this patch, I'm looking at the other patches now.

- Arnaldo

Thread

[PATCH 0/5] Refactoring with ltrim() and rtrim() Taeung Song <treeze.taeung@gmail.com> - 2017-04-07 16:30 +0200
  [PATCH 2/5] perf stat: Refactor the code to strip csv output with ltrim() Taeung Song <treeze.taeung@gmail.com> - 2017-04-07 16:30 +0200
    Re: [PATCH 2/5] perf stat: Refactor the code to strip csv output  with ltrim() Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-04-07 17:10 +0200
      Re: [PATCH 2/5] perf stat: Refactor the code to strip csv output with  ltrim() Taeung Song <treeze.taeung@gmail.com> - 2017-04-08 01:50 +0200
  [PATCH 3/5] perf ui browser: Refactor the code to parse color configs with ltrim() Taeung Song <treeze.taeung@gmail.com> - 2017-04-07 16:30 +0200
  [PATCH 1/5] perf annotate: Refactor the code to parse disassemble lines with {l,r}trim() Taeung Song <treeze.taeung@gmail.com> - 2017-04-07 16:30 +0200
    Re: [PATCH 1/5] perf annotate: Refactor the code to parse  disassemble lines with {l,r}trim() Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-04-07 17:10 +0200
      Re: [PATCH 1/5] perf annotate: Refactor the code to parse disassemble  lines with {l,r}trim() Taeung Song <treeze.taeung@gmail.com> - 2017-04-07 20:10 +0200
    Re: [PATCH 1/5] perf annotate: Refactor the code to parse  disassemble lines with {l,r}trim() Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-04-07 17:10 +0200
      Re: [PATCH 1/5] perf annotate: Refactor the code to parse disassemble  lines with {l,r}trim() Taeung Song <treeze.taeung@gmail.com> - 2017-04-08 02:20 +0200
    Re: [PATCH 1/5] perf annotate: Refactor the code to parse  disassemble lines with {l,r}trim() Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-04-07 17:10 +0200

csiph-web