Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1619696
| From | Juergen Borleis <jbe@pengutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support |
| Date | 2017-04-10 10:00 +0200 |
| Message-ID | <tuCoV-6gF-1@gated-at.bofh.it> (permalink) |
| References | <ttxhD-4AV-7@gated-at.bofh.it> <ttxhD-4AV-15@gated-at.bofh.it> <ttCr0-7Ki-17@gated-at.bofh.it> |
| Organization | Pengutronix e.K. |
Hi Andrew,
On Friday 07 April 2017 15:40:07 Andrew Lunn wrote:
> > +Optional properties:
> > +
> > +- reset-gpios: GPIO to be used to reset the whole device, always low
> > active
>
> I would avoid the always low active comment. The input to the switch
> is active low. But i've seen designs with an inverter in the reset
> path, so from the perspective of the GPIO it would be active high. The
> device tree binding allows for this, via the flags. And since you use
> the gpiod API, it should all just work.
>
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port@0 { /* RMII fixed link to master */
> > + reg = <0>;
> > + label = "cpu";
> > + ethernet = <&master>;
> > + };
> > +
> > + port@1 { /* external port 1 */
> > + compatible = "ethernet-phy-ieee802.3-c22";
> > + reg = <1>;
> > + label = "lan1;
> > + };
>
> These are not PHY nodes, so does this compatible string do anything?
I removed them and nothing changed.
Regards,
Juergen
--
Pengutronix e.K. | Juergen Borleis |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHv2] net: dsa: add SMSC/Microchip LAN9303 three port ethernet switch driver Juergen Borleis <jbe@pengutronix.de> - 2017-04-07 10:20 +0200
[PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support Juergen Borleis <jbe@pengutronix.de> - 2017-04-07 10:20 +0200
Re: [PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support Andrew Lunn <andrew@lunn.ch> - 2017-04-07 15:50 +0200
Re: [PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support Juergen Borleis <jbe@pengutronix.de> - 2017-04-10 10:00 +0200
[PATCH v2 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Juergen Borleis <jbe@pengutronix.de> - 2017-04-07 10:20 +0200
Re: [PATCH v2 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 David Miller <davem@davemloft.net> - 2017-04-07 15:40 +0200
Re: [PATCH v2 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Andrew Lunn <andrew@lunn.ch> - 2017-04-07 16:40 +0200
Re: [PATCH v2 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Juergen Borleis <jbe@pengutronix.de> - 2017-04-10 09:50 +0200
Re: [PATCH v2 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Andrew Lunn <andrew@lunn.ch> - 2017-04-10 15:30 +0200
[PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support Juergen Borleis <jbe@pengutronix.de> - 2017-04-07 10:20 +0200
Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support Andrew Lunn <andrew@lunn.ch> - 2017-04-07 16:30 +0200
Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support David Miller <davem@davemloft.net> - 2017-04-07 16:30 +0200
Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support Andrew Lunn <andrew@lunn.ch> - 2017-04-07 17:00 +0200
Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support Andrew Lunn <andrew@lunn.ch> - 2017-04-07 17:10 +0200
[PATCH v2 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Juergen Borleis <jbe@pengutronix.de> - 2017-04-07 10:20 +0200
Re: [PATCH v2 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Andrew Lunn <andrew@lunn.ch> - 2017-04-07 15:10 +0200
Re: [PATCH v2 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Juergen Borleis <jbe@pengutronix.de> - 2017-04-10 09:20 +0200
Re: [PATCH v2 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Andrew Lunn <andrew@lunn.ch> - 2017-04-10 15:20 +0200
csiph-web