Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1618799
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 |
| Date | 2017-04-07 15:40 +0200 |
| Message-ID | <ttChj-7G0-3@gated-at.bofh.it> (permalink) |
| References | <ttxhD-4AV-7@gated-at.bofh.it> <ttxhE-4AV-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Juergen Borleis <jbe@pengutronix.de>
Date: Fri, 7 Apr 2017 10:15:00 +0200
> +static inline struct lan9303 *ds_to_lan9303(struct dsa_switch *ds)
> +{
> + return (struct lan9303 *)ds->priv;
> +}
You never need an explicit cast from a void pointer to another kind of
pointer. Please remove this.
In fact, this therefore makes the helper kind of useless and you can
just simply go:
struct lan9303_priv *priv = ds->priv;
everywhere.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHv2] net: dsa: add SMSC/Microchip LAN9303 three port ethernet switch driver Juergen Borleis <jbe@pengutronix.de> - 2017-04-07 10:20 +0200
[PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support Juergen Borleis <jbe@pengutronix.de> - 2017-04-07 10:20 +0200
Re: [PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support Andrew Lunn <andrew@lunn.ch> - 2017-04-07 15:50 +0200
Re: [PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support Juergen Borleis <jbe@pengutronix.de> - 2017-04-10 10:00 +0200
[PATCH v2 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Juergen Borleis <jbe@pengutronix.de> - 2017-04-07 10:20 +0200
Re: [PATCH v2 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 David Miller <davem@davemloft.net> - 2017-04-07 15:40 +0200
Re: [PATCH v2 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Andrew Lunn <andrew@lunn.ch> - 2017-04-07 16:40 +0200
Re: [PATCH v2 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Juergen Borleis <jbe@pengutronix.de> - 2017-04-10 09:50 +0200
Re: [PATCH v2 2/4] net: dsa: add new DSA switch driver for the SMSC-LAN9303 Andrew Lunn <andrew@lunn.ch> - 2017-04-10 15:30 +0200
[PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support Juergen Borleis <jbe@pengutronix.de> - 2017-04-07 10:20 +0200
Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support Andrew Lunn <andrew@lunn.ch> - 2017-04-07 16:30 +0200
Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support David Miller <davem@davemloft.net> - 2017-04-07 16:30 +0200
Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support Andrew Lunn <andrew@lunn.ch> - 2017-04-07 17:00 +0200
Re: [PATCH v2 4/4] net: dsa: LAN9303: add MDIO managed mode support Andrew Lunn <andrew@lunn.ch> - 2017-04-07 17:10 +0200
[PATCH v2 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Juergen Borleis <jbe@pengutronix.de> - 2017-04-07 10:20 +0200
Re: [PATCH v2 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Andrew Lunn <andrew@lunn.ch> - 2017-04-07 15:10 +0200
Re: [PATCH v2 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Juergen Borleis <jbe@pengutronix.de> - 2017-04-10 09:20 +0200
Re: [PATCH v2 1/4] net: dsa: add support for the SMSC-LAN9303 tagging format Andrew Lunn <andrew@lunn.ch> - 2017-04-10 15:20 +0200
csiph-web