Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1614386

Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning

From Joe Perches <joe@perches.com>
Newsgroups linux.kernel
Subject Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning
Date 2017-04-01 05:40 +0200
Message-ID <tri3o-5wb-13@gated-at.bofh.it> (permalink)
References <trguC-4hQ-5@gated-at.bofh.it> <trguC-4hQ-9@gated-at.bofh.it> <tri3o-5wb-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sat, 2017-04-01 at 04:32 +0100, Al Viro wrote:
> On Fri, Mar 31, 2017 at 06:59:19PM -0700, Chewie Lin wrote:
> > Replace string with formatted arguments in the dev_warn() call. It removes
> > the checkpatch warning:
> > 
> > 	WARNING: Prefer using "%s", __func__ to embedded function names
[]
> Again, checkpatch warning is badly written

In your opinion, what wording would be better?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] eudyptula challenge Chewie Lin <linsh@oregonstate.edu> - 2017-04-01 04:00 +0200
  [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin <linsh@oregonstate.edu> - 2017-04-01 04:00 +0200
    Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch  warning Joe Perches <joe@perches.com> - 2017-04-01 04:20 +0200
    Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch  warning Randy Dunlap <rdunlap@infradead.org> - 2017-04-01 04:20 +0200
      Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch  warning Joe Perches <joe@perches.com> - 2017-04-01 04:50 +0200
        Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch  warning Chewie Lin <linsh@oregonstate.edu> - 2017-04-01 05:20 +0200
          Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch  warning Joe Perches <joe@perches.com> - 2017-04-01 05:40 +0200
    Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch  warning Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-01 05:40 +0200
      Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch  warning Joe Perches <joe@perches.com> - 2017-04-01 05:40 +0200
        Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch  warning Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-01 05:50 +0200
          Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch  warning Joe Perches <joe@perches.com> - 2017-04-01 06:00 +0200
            Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch  warning Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-01 06:10 +0200
              Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch  warning Joe Perches <joe@perches.com> - 2017-04-01 06:30 +0200
      Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch  warning Chewie Lin <linsh@oregonstate.edu> - 2017-04-01 06:40 +0200

csiph-web