Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1614384
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning |
| Date | 2017-04-01 05:40 +0200 |
| Message-ID | <tri3o-5wb-11@gated-at.bofh.it> (permalink) |
| References | <trguC-4hQ-5@gated-at.bofh.it> <trguC-4hQ-9@gated-at.bofh.it> <trgNZ-4N2-23@gated-at.bofh.it> <trhgZ-4Xz-1@gated-at.bofh.it> <trhK1-5pA-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 2017-03-31 at 20:18 -0700, Chewie Lin wrote:
> These are good points, but any feedback on the dev_warn() call itself?
> I was trying to fix the checkpatch warning on my first try.
Using "%s" with a long string is generally inefficient.
Compare the compiled object size of
printf("%s is %d\n", "Long string", 1);
to
printf("Long string is %d\n", 1);
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] eudyptula challenge Chewie Lin <linsh@oregonstate.edu> - 2017-04-01 04:00 +0200
[PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin <linsh@oregonstate.edu> - 2017-04-01 04:00 +0200
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Joe Perches <joe@perches.com> - 2017-04-01 04:20 +0200
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Randy Dunlap <rdunlap@infradead.org> - 2017-04-01 04:20 +0200
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Joe Perches <joe@perches.com> - 2017-04-01 04:50 +0200
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin <linsh@oregonstate.edu> - 2017-04-01 05:20 +0200
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Joe Perches <joe@perches.com> - 2017-04-01 05:40 +0200
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-01 05:40 +0200
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Joe Perches <joe@perches.com> - 2017-04-01 05:40 +0200
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-01 05:50 +0200
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Joe Perches <joe@perches.com> - 2017-04-01 06:00 +0200
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-01 06:10 +0200
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Joe Perches <joe@perches.com> - 2017-04-01 06:30 +0200
Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin <linsh@oregonstate.edu> - 2017-04-01 06:40 +0200
csiph-web