Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589810

Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations.

Show all headers | View raw

On Tue, Feb 28, 2017 at 10:34 PM, Joe Perches <joe@perches.com> wrote:
> On Tue, 2017-02-28 at 21:52 +0200, Alexander Kapshuk wrote:
>> Use a single fmt string with appropriate verbs as conversion specifiers,
>> followed by the original string literals and the integer argument
>> instead of using a backslash to escape a new line embedded inbetween
>> quoted string literals passed as fmt arguments to dev_err() invoked in
>> drivers/staging/fbtft/fb_ssd1331.c.
>
> trivia:
>
>> diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c
>> index 26f24e3..6d03041 100644
>> --- a/drivers/staging/fbtft/fb_ssd1331.c
>> +++ b/drivers/staging/fbtft/fb_ssd1331.c
>> @@ -129,17 +129,19 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
>>
>>       for (i = 0; i < 63; i++) {
>>               if (i > 0 && curves[i] < 2) {
>> -                     dev_err(par->info->device,
>> -                             "Illegal value in Grayscale Lookup Table at index %d. " \
>> -                             "Must be greater than 1\n", i);
>> +                     dev_err(par->info->device, "%s %d. %s\n",
>> +                             "Illegal value in Grayscale Lookup Table at index",
>
> Most prefer the use of invalid not illegal.
>

Thanks for your feedback.

I don't mind substituting invalid for illegal, unless the maintainers
preferred to do that themselves instead.
My patch was addressing a checkpatch.pl warning only.

I'll wait a bit more to hear from the maintainers, before going ahead
and sending another patch in.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations. Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2017-02-28 21:10 +0100
  Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about  unnecessary line continuations. Joe Perches <joe@perches.com> - 2017-02-28 21:40 +0100
    Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about  unnecessary line continuations. Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2017-02-28 22:40 +0100
  Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about  unnecessary line continuations. Greg KH <gregkh@linuxfoundation.org> - 2017-03-01 11:00 +0100
    [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2017-03-04 10:10 +0100

csiph-web