Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589715

Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters

Show all headers | View raw

On Tue, Feb 28, 2017 at 08:26:19PM +0100, Greg KH wrote:
> On Tue, Feb 28, 2017 at 11:59:36AM +0900, Chetan Sethi wrote:
> > This patch fixes warning of line over 80 characters, as issued by
> > checkpatch.pl
> > 
> > Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
> > ---
> > v2:
> >  - split multiple changes across different patches
> > v3:
> >  - mentioned patch revision in subject
> > v4:
> >  - modified description to exclude mention of patch number from changelog
> > v5:
> >  - updated series for removing additional checkpatch error introduced
> > 
> >  drivers/staging/ks7010/ks_wlan.h | 11 ++++++-----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
> > index 9ab80e1..668202d 100644
> > --- a/drivers/staging/ks7010/ks_wlan.h
> > +++ b/drivers/staging/ks7010/ks_wlan.h
> > @@ -18,10 +18,10 @@
> >  #include <linux/kernel.h>
> >  #include <linux/module.h>
> >  
> > -#include <linux/spinlock.h>	/* spinlock_t                                   */
> > -#include <linux/sched.h>	/* wait_queue_head_t                            */
> > -#include <linux/types.h>	/* pid_t                                        */
> > -#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff     */
> > +#include <linux/spinlock.h>	/* spinlock_t */
> > +#include <linux/sched.h>	/* wait_queue_head_t */
> > +#include <linux/types.h>	/* pid_t */
> > +#include <linux/netdevice.h>	/* struct net_device_stats,  struct sk_buff */
> >  #include <linux/etherdevice.h>
> >  #include <linux/wireless.h>
> >  #include <linux/atomic.h>	/* struct atomic_t */
> > @@ -36,7 +36,8 @@
> >  
> >  #ifdef KS_WLAN_DEBUG
> >  #define DPRINTK(n, fmt, args...) \
> > -                 if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
> > +                 if (KS_WLAN_DEBUG > (n)) \
> 
> Why did you not use a tab here to indent this line as you were modifying
> it?

Oh nevermind, you change this up later on in the series...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Chetan Sethi <cpsethi369@gmail.com> - 2017-02-26 08:40 +0100
  Re: [PATCH v4 2/6] staging: ks7010: fix coding style issue of  enclosing complex macro value in parentheses Greg KH <gregkh@linuxfoundation.org> - 2017-02-27 15:50 +0100
    [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi <cpsethi369@gmail.com> - 2017-02-28 06:00 +0100
      [PATCH v5 3/5] staging: ks7010: fix coding style issue of using pr_notice instead of printk Chetan Sethi <cpsethi369@gmail.com> - 2017-02-28 07:20 +0100
      Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line  over 80 characters Greg KH <gregkh@linuxfoundation.org> - 2017-02-28 20:30 +0100
      Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line  over 80 characters Greg KH <gregkh@linuxfoundation.org> - 2017-02-28 20:40 +0100

csiph-web