Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1589714
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: ata: WARNING in ata_sff_qc_issue |
| Date | 2017-02-28 20:30 +0100 |
| Message-ID | <tfVDb-lh-1@gated-at.bofh.it> (permalink) |
| References | <tfRgd-5JN-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello, On Tue, Feb 28, 2017 at 03:33:48PM +0100, Dmitry Vyukov wrote: > If the WARNING is merely to inform user about invalid protocol, please > issue a single line pr_err without the stack trace (invalid protocol > value may be more interesting). Yeah, the warning is harmless. The code was written before passthrough support and just assumed that nobody higher up in the stack should be issuing unsupported protocols and warned on such cases as a precaution. I'm just gonna drop the WARN. The error code to sg command should be enough to indicate the failure. Thanks. -- tejun
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
ata: WARNING in ata_sff_qc_issue Dmitry Vyukov <dvyukov@google.com> - 2017-02-28 15:50 +0100 Re: ata: WARNING in ata_sff_qc_issue Tejun Heo <tj@kernel.org> - 2017-02-28 20:30 +0100 Re: ata: WARNING in ata_sff_qc_issue Tejun Heo <tj@kernel.org> - 2017-03-06 21:40 +0100
csiph-web