Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588693

Re: [PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses

Show all headers | View raw

On Sun, Feb 26, 2017 at 04:01:22PM +0900, Chetan Sethi wrote:
> This patch fixes error of enclosing complex macro value in parentheses,
> error as issued by checkpatch
> 
> Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
> ---
> v2:
>  - split multiple changes across different patches
> v3:
>  - mentioned patch revision in subject
>  - incorporated review comment of correct indentation for do statement
> v4:
>  - modified description to exclude mention of patch number from changelog
> 
>  drivers/staging/ks7010/ks_wlan.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
> index 668202d..33d6b28 100644
> --- a/drivers/staging/ks7010/ks_wlan.h
> +++ b/drivers/staging/ks7010/ks_wlan.h
> @@ -36,8 +36,10 @@
>  
>  #ifdef KS_WLAN_DEBUG
>  #define DPRINTK(n, fmt, args...) \
> -                 if (KS_WLAN_DEBUG > (n)) \
> -			printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
> +        do { \

This line is not correct, again, it's ok if existing code has checkpatch
issues, but you should never _add_ any new ones.

Please fix this up and resend the series.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Chetan Sethi <cpsethi369@gmail.com> - 2017-02-26 08:40 +0100
  Re: [PATCH v4 2/6] staging: ks7010: fix coding style issue of  enclosing complex macro value in parentheses Greg KH <gregkh@linuxfoundation.org> - 2017-02-27 15:50 +0100
    [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi <cpsethi369@gmail.com> - 2017-02-28 06:00 +0100
      [PATCH v5 3/5] staging: ks7010: fix coding style issue of using pr_notice instead of printk Chetan Sethi <cpsethi369@gmail.com> - 2017-02-28 07:20 +0100
      Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line  over 80 characters Greg KH <gregkh@linuxfoundation.org> - 2017-02-28 20:30 +0100
      Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line  over 80 characters Greg KH <gregkh@linuxfoundation.org> - 2017-02-28 20:40 +0100

csiph-web