Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1588291 > unrolled thread
| Started by | Chetan Sethi <cpsethi369@gmail.com> |
|---|---|
| First post | 2017-02-26 08:40 +0100 |
| Last post | 2017-02-28 20:40 +0100 |
| Articles | 6 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Chetan Sethi <cpsethi369@gmail.com> - 2017-02-26 08:40 +0100
Re: [PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Greg KH <gregkh@linuxfoundation.org> - 2017-02-27 15:50 +0100
[PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi <cpsethi369@gmail.com> - 2017-02-28 06:00 +0100
[PATCH v5 3/5] staging: ks7010: fix coding style issue of using pr_notice instead of printk Chetan Sethi <cpsethi369@gmail.com> - 2017-02-28 07:20 +0100
Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Greg KH <gregkh@linuxfoundation.org> - 2017-02-28 20:30 +0100
Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Greg KH <gregkh@linuxfoundation.org> - 2017-02-28 20:40 +0100
| From | Chetan Sethi <cpsethi369@gmail.com> |
|---|---|
| Date | 2017-02-26 08:40 +0100 |
| Subject | [PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses |
| Message-ID | <tf1AZ-3zL-9@gated-at.bofh.it> |
This patch fixes error of enclosing complex macro value in parentheses,
error as issued by checkpatch
Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
- incorporated review comment of correct indentation for do statement
v4:
- modified description to exclude mention of patch number from changelog
drivers/staging/ks7010/ks_wlan.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 668202d..33d6b28 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -36,8 +36,10 @@
#ifdef KS_WLAN_DEBUG
#define DPRINTK(n, fmt, args...) \
- if (KS_WLAN_DEBUG > (n)) \
- printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
+ do { \
+ if (KS_WLAN_DEBUG > (n)) \
+ printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
+ } while (0)
#else
#define DPRINTK(n, fmt, args...)
#endif
--
2.7.4
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-27 15:50 +0100 |
| Subject | Re: [PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses |
| Message-ID | <tfuMH-6Wf-27@gated-at.bofh.it> |
| In reply to | #1588291 |
On Sun, Feb 26, 2017 at 04:01:22PM +0900, Chetan Sethi wrote:
> This patch fixes error of enclosing complex macro value in parentheses,
> error as issued by checkpatch
>
> Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
> ---
> v2:
> - split multiple changes across different patches
> v3:
> - mentioned patch revision in subject
> - incorporated review comment of correct indentation for do statement
> v4:
> - modified description to exclude mention of patch number from changelog
>
> drivers/staging/ks7010/ks_wlan.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
> index 668202d..33d6b28 100644
> --- a/drivers/staging/ks7010/ks_wlan.h
> +++ b/drivers/staging/ks7010/ks_wlan.h
> @@ -36,8 +36,10 @@
>
> #ifdef KS_WLAN_DEBUG
> #define DPRINTK(n, fmt, args...) \
> - if (KS_WLAN_DEBUG > (n)) \
> - printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
> + do { \
This line is not correct, again, it's ok if existing code has checkpatch
issues, but you should never _add_ any new ones.
Please fix this up and resend the series.
thanks,
greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Chetan Sethi <cpsethi369@gmail.com> |
|---|---|
| Date | 2017-02-28 06:00 +0100 |
| Subject | [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters |
| Message-ID | <tfGkN-6Kj-9@gated-at.bofh.it> |
| In reply to | #1588693 |
This patch fixes warning of line over 80 characters, as issued by checkpatch.pl Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject v4: - modified description to exclude mention of patch number from changelog v5: - updated series for removing additional checkpatch error introduced drivers/staging/ks7010/ks_wlan.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 9ab80e1..668202d 100644 --- a/drivers/staging/ks7010/ks_wlan.h +++ b/drivers/staging/ks7010/ks_wlan.h @@ -18,10 +18,10 @@ #include <linux/kernel.h> #include <linux/module.h> -#include <linux/spinlock.h> /* spinlock_t */ -#include <linux/sched.h> /* wait_queue_head_t */ -#include <linux/types.h> /* pid_t */ -#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ +#include <linux/spinlock.h> /* spinlock_t */ +#include <linux/sched.h> /* wait_queue_head_t */ +#include <linux/types.h> /* pid_t */ +#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ #include <linux/etherdevice.h> #include <linux/wireless.h> #include <linux/atomic.h> /* struct atomic_t */ @@ -36,7 +36,8 @@ #ifdef KS_WLAN_DEBUG #define DPRINTK(n, fmt, args...) \ - if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) + if (KS_WLAN_DEBUG > (n)) \ + printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) #else #define DPRINTK(n, fmt, args...) #endif -- 2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Chetan Sethi <cpsethi369@gmail.com> |
|---|---|
| Date | 2017-02-28 07:20 +0100 |
| Subject | [PATCH v5 3/5] staging: ks7010: fix coding style issue of using pr_notice instead of printk |
| Message-ID | <tfJiF-uX-3@gated-at.bofh.it> |
| In reply to | #1589178 |
Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog
- updated subject to include driver name
v5:
- updated series for removing additional checkpatch error introduced
drivers/staging/ks7010/ks_wlan.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 94b648b..78beca7 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -38,7 +38,7 @@
#define DPRINTK(n, fmt, args...) \
do { \
if (KS_WLAN_DEBUG > (n)) \
- printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
+ pr_notice("%s: "fmt, __FUNCTION__, ## args); \
} while (0)
#else
#define DPRINTK(n, fmt, args...)
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-28 20:30 +0100 |
| Subject | Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters |
| Message-ID | <tfVDb-lh-7@gated-at.bofh.it> |
| In reply to | #1589178 |
On Tue, Feb 28, 2017 at 08:26:19PM +0100, Greg KH wrote: > On Tue, Feb 28, 2017 at 11:59:36AM +0900, Chetan Sethi wrote: > > This patch fixes warning of line over 80 characters, as issued by > > checkpatch.pl > > > > Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> > > --- > > v2: > > - split multiple changes across different patches > > v3: > > - mentioned patch revision in subject > > v4: > > - modified description to exclude mention of patch number from changelog > > v5: > > - updated series for removing additional checkpatch error introduced > > > > drivers/staging/ks7010/ks_wlan.h | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h > > index 9ab80e1..668202d 100644 > > --- a/drivers/staging/ks7010/ks_wlan.h > > +++ b/drivers/staging/ks7010/ks_wlan.h > > @@ -18,10 +18,10 @@ > > #include <linux/kernel.h> > > #include <linux/module.h> > > > > -#include <linux/spinlock.h> /* spinlock_t */ > > -#include <linux/sched.h> /* wait_queue_head_t */ > > -#include <linux/types.h> /* pid_t */ > > -#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ > > +#include <linux/spinlock.h> /* spinlock_t */ > > +#include <linux/sched.h> /* wait_queue_head_t */ > > +#include <linux/types.h> /* pid_t */ > > +#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ > > #include <linux/etherdevice.h> > > #include <linux/wireless.h> > > #include <linux/atomic.h> /* struct atomic_t */ > > @@ -36,7 +36,8 @@ > > > > #ifdef KS_WLAN_DEBUG > > #define DPRINTK(n, fmt, args...) \ > > - if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) > > + if (KS_WLAN_DEBUG > (n)) \ > > Why did you not use a tab here to indent this line as you were modifying > it? Oh nevermind, you change this up later on in the series...
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-28 20:40 +0100 |
| Subject | Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters |
| Message-ID | <tfVDb-lh-9@gated-at.bofh.it> |
| In reply to | #1589178 |
On Tue, Feb 28, 2017 at 11:59:36AM +0900, Chetan Sethi wrote: > This patch fixes warning of line over 80 characters, as issued by > checkpatch.pl > > Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> > --- > v2: > - split multiple changes across different patches > v3: > - mentioned patch revision in subject > v4: > - modified description to exclude mention of patch number from changelog > v5: > - updated series for removing additional checkpatch error introduced > > drivers/staging/ks7010/ks_wlan.h | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h > index 9ab80e1..668202d 100644 > --- a/drivers/staging/ks7010/ks_wlan.h > +++ b/drivers/staging/ks7010/ks_wlan.h > @@ -18,10 +18,10 @@ > #include <linux/kernel.h> > #include <linux/module.h> > > -#include <linux/spinlock.h> /* spinlock_t */ > -#include <linux/sched.h> /* wait_queue_head_t */ > -#include <linux/types.h> /* pid_t */ > -#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ > +#include <linux/spinlock.h> /* spinlock_t */ > +#include <linux/sched.h> /* wait_queue_head_t */ > +#include <linux/types.h> /* pid_t */ > +#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ > #include <linux/etherdevice.h> > #include <linux/wireless.h> > #include <linux/atomic.h> /* struct atomic_t */ > @@ -36,7 +36,8 @@ > > #ifdef KS_WLAN_DEBUG > #define DPRINTK(n, fmt, args...) \ > - if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) > + if (KS_WLAN_DEBUG > (n)) \ Why did you not use a tab here to indent this line as you were modifying it? thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web