Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1588298

Re: [PATCH] ASoC: dwc: remove 'out of memory' message

Path csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Takashi Sakamoto <o-takashi@sakamocchi.jp>
Newsgroups linux.kernel
Subject Re: [PATCH] ASoC: dwc: remove 'out of memory' message
Date Sun, 26 Feb 2017 09:10:01 +0100
Message-ID <tf241-3YV-5@gated-at.bofh.it> (permalink)
References <teIoF-6UJ-7@gated-at.bofh.it>
X-Virus-Status clean(LOLIPOP-Fsecure)
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0
MIME-Version 1.0
Content-Type text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 33
Organization linux.* mail to news gateway
X-Original-Cc Jose.Abreu@synopsys.com, alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, broonie@kernel.org, s.nawrocki@samsung.com, colin.king@canonical.com
X-Original-Date Sun, 26 Feb 2017 17:03:22 +0900
X-Original-Message-ID <9da9efc3-cd9b-70a5-a764-e8be32e67d13@sakamocchi.jp>
X-Original-References <20170225110323.7506-1-michelcatalin@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1588298

Show key headers only | View raw


Hi,

On Feb 25 2017 20:03, Mihai Burduselu wrote:
> Reported by checkpatch.pl
> Signed-off-by: Mihai Burduselu <michelcatalin@gmail.com>
> ---
>  sound/soc/dwc/designware_i2s.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
> index 9c46e4112026..6479768cc6a1 100644
> --- a/sound/soc/dwc/designware_i2s.c
> +++ b/sound/soc/dwc/designware_i2s.c
> @@ -611,10 +611,8 @@ static int dw_i2s_probe(struct platform_device *pdev)
>  	const char *clk_id;
>
>  	dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
> -	if (!dev) {
> -		dev_warn(&pdev->dev, "kzalloc fail\n");
> +	if (!dev)

The line for 'dev_warn()' should be kept.

>  		return -ENOMEM;
> -	}
>
>  	dw_i2s_dai = devm_kzalloc(&pdev->dev, sizeof(*dw_i2s_dai), GFP_KERNEL);
>  	if (!dw_i2s_dai)


Regards

Takashi Sakamoto

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ASoC: dwc: remove 'out of memory' message Mihai Burduselu <michelcatalin@gmail.com> - 2017-02-25 12:10 +0100
  Re: [PATCH] ASoC: dwc: remove 'out of memory' message Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2017-02-26 09:10 +0100
    Re: [PATCH] ASoC: dwc: remove 'out of memory' message Takashi Iwai <tiwai@suse.de> - 2017-02-28 16:40 +0100

csiph-web