Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588299

Re: [PATCH] ASoC: spear: Remove redundant message

Show all headers | View raw

On Feb 25 2017 19:33, dspmihai wrote:
> This was reported by checkpatch.pl
>
> Signed-off-by: Despotovici Mihai <despotovici.mihai@gmail.com>
> ---
>  sound/soc/spear/spdif_in.c  | 4 +---
>  sound/soc/spear/spdif_out.c | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/sound/soc/spear/spdif_in.c b/sound/soc/spear/spdif_in.c
> index 977a078..0f3b1a8 100644
> --- a/sound/soc/spear/spdif_in.c
> +++ b/sound/soc/spear/spdif_in.c
> @@ -216,10 +216,8 @@ static int spdif_in_probe(struct platform_device *pdev)
>  		return -EINVAL;
>
>  	host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
> -	if (!host) {
> -		dev_warn(&pdev->dev, "kzalloc fail\n");
> +	if (!host)

The line for dev_warn() should be kept.

>  		return -ENOMEM;
> -	}
>
>  	host->io_base = io_base;
>  	host->irq = platform_get_irq(pdev, 0);
> diff --git a/sound/soc/spear/spdif_out.c b/sound/soc/spear/spdif_out.c
> index 0a72d52..58d5843 100644
> --- a/sound/soc/spear/spdif_out.c
> +++ b/sound/soc/spear/spdif_out.c
> @@ -282,10 +282,8 @@ static int spdif_out_probe(struct platform_device *pdev)
>  	int ret;
>
>  	host = devm_kzalloc(&pdev->dev, sizeof(*host), GFP_KERNEL);
> -	if (!host) {
> -		dev_warn(&pdev->dev, "kzalloc fail\n");
> +	if (!host)

Ditto.

>  		return -ENOMEM;
> -	}
>
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	host->io_base = devm_ioremap_resource(&pdev->dev, res);

Takashi Sakamoto

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: spear: Remove redundant message dspmihai <despotovici.mihai@gmail.com> - 2017-02-25 11:50 +0100
  Re: [PATCH] ASoC: spear: Remove redundant message Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2017-02-26 09:10 +0100

csiph-web