Re: [PATCH] ASoC: rockchip: i2s: Remove unnecessary 'out of memory' message

From	Takashi Sakamoto <o-takashi@sakamocchi.jp>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: rockchip: i2s: Remove unnecessary 'out of memory' message
Date	2017-02-26 09:10 +0100
Message-ID	<tf241-3YV-1@gated-at.bofh.it> (permalink)
References	<teHLY-6lF-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Feb 25 2017 19:18, Mihai-Valentin DUMITRU wrote:
> This was reported by checkpatch.pl
>
> Signed-off-by: Mihai-Valentin DUMITRU <mihai.dumitru2201@gmail.com>
> ---
>  sound/soc/rockchip/rockchip_i2s.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
> index 974915cb4c4f..d02a1045fc0b 100644
> --- a/sound/soc/rockchip/rockchip_i2s.c
> +++ b/sound/soc/rockchip/rockchip_i2s.c
> @@ -551,10 +551,8 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
>  	int val;
>
>  	i2s = devm_kzalloc(&pdev->dev, sizeof(*i2s), GFP_KERNEL);
> -	if (!i2s) {
> -		dev_err(&pdev->dev, "Can't allocate rk_i2s_dev\n");
> +	if (!i2s)

The line for dev_warn() should be kept.

>  		return -ENOMEM;
> -	}
>
>  	i2s->dev = &pdev->dev;


Regards

Takashi Sakamoto

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: rockchip: i2s: Remove unnecessary 'out of memory' message Mihai-Valentin DUMITRU <mihai.dumitru2201@gmail.com> - 2017-02-25 11:30 +0100
  Re: [PATCH] ASoC: rockchip: i2s: Remove unnecessary 'out of memory'  message Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2017-02-26 09:10 +0100

csiph-web