Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589569

Re: [PATCH] ASoC: dwc: remove 'out of memory' message

Show all headers | View raw

On Sun, 26 Feb 2017 09:03:22 +0100,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On Feb 25 2017 20:03, Mihai Burduselu wrote:
> > Reported by checkpatch.pl
> > Signed-off-by: Mihai Burduselu <michelcatalin@gmail.com>
> > ---
> >  sound/soc/dwc/designware_i2s.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
> > index 9c46e4112026..6479768cc6a1 100644
> > --- a/sound/soc/dwc/designware_i2s.c
> > +++ b/sound/soc/dwc/designware_i2s.c
> > @@ -611,10 +611,8 @@ static int dw_i2s_probe(struct platform_device *pdev)
> >  	const char *clk_id;
> >
> >  	dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
> > -	if (!dev) {
> > -		dev_warn(&pdev->dev, "kzalloc fail\n");
> > +	if (!dev)
> 
> The line for 'dev_warn()' should be kept.

In general, people regard it superfluous since kmalloc() itself
already gives a kernel warning at an allocation error.  So removing
the message is OK in that sense.

However, the problem of this (and lots of other) patch is that it
doesn't give proper information.  Instead, in a single line, it merely
declares checkpatch.pl as a bible.  Very helpful, eh?

So, please reconsider the changelog when you submit this kind of
patches.


thanks,

Takashi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: dwc: remove 'out of memory' message Mihai Burduselu <michelcatalin@gmail.com> - 2017-02-25 12:10 +0100
  Re: [PATCH] ASoC: dwc: remove 'out of memory' message Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2017-02-26 09:10 +0100
    Re: [PATCH] ASoC: dwc: remove 'out of memory' message Takashi Iwai <tiwai@suse.de> - 2017-02-28 16:40 +0100
      Re: [PATCH] ASoC: dwc: remove 'out of memory' message Mark Brown <broonie@kernel.org> - 2017-03-07 22:10 +0100

csiph-web