Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1586296

[PATCH 3/3] [media] si4713: Add OF device ID table

Show all headers | View raw

The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.

But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/media/radio/si4713/si4713.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/media/radio/si4713/si4713.c b/drivers/media/radio/si4713/si4713.c
index 60f026a58076..f4a53f1e856e 100644
--- a/drivers/media/radio/si4713/si4713.c
+++ b/drivers/media/radio/si4713/si4713.c
@@ -1656,9 +1656,18 @@ static const struct i2c_device_id si4713_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, si4713_id);
 
+#if IS_ENABLED(CONFIG_OF)
+static const struct of_device_id si4713_of_match[] = {
+	{ .compatible = "silabs,si4713" },
+	{ },
+};
+MODULE_DEVICE_TABLE(of, si4713_of_match);
+#endif
+
 static struct i2c_driver si4713_i2c_driver = {
 	.driver		= {
 		.name	= "si4713",
+		.of_match_table = of_match_ptr(si4713_of_match),
 	},
 	.probe		= si4713_probe,
 	.remove         = si4713_remove,
-- 
2.9.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-22 17:30 +0100
  [PATCH 2/3] [media] tc358743: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-22 17:30 +0100
    Re: [PATCH 2/3] [media] tc358743: Add OF device ID table "Mats Randgaard (matrandg)" <matrandg@cisco.com> - 2017-02-22 21:30 +0100
  [PATCH 3/3] [media] si4713: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-22 17:30 +0100
  Re: [PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table Guennadi Liakhovetski <g.liakhovetski@gmx.de> - 2017-02-26 21:00 +0100

csiph-web