Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1586294 > unrolled thread
| Started by | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| First post | 2017-02-22 17:30 +0100 |
| Last post | 2017-02-26 21:00 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-22 17:30 +0100
[PATCH 2/3] [media] tc358743: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-22 17:30 +0100
Re: [PATCH 2/3] [media] tc358743: Add OF device ID table "Mats Randgaard (matrandg)" <matrandg@cisco.com> - 2017-02-22 21:30 +0100
[PATCH 3/3] [media] si4713: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-22 17:30 +0100
Re: [PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table Guennadi Liakhovetski <g.liakhovetski@gmx.de> - 2017-02-26 21:00 +0100
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2017-02-22 17:30 +0100 |
| Subject | [PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table |
| Message-ID | <tdHXH-4rY-1@gated-at.bofh.it> |
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/media/i2c/soc_camera/ov5642.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/media/i2c/soc_camera/ov5642.c b/drivers/media/i2c/soc_camera/ov5642.c
index 3d185bd622a3..1926f382dfce 100644
--- a/drivers/media/i2c/soc_camera/ov5642.c
+++ b/drivers/media/i2c/soc_camera/ov5642.c
@@ -1063,9 +1063,18 @@ static const struct i2c_device_id ov5642_id[] = {
};
MODULE_DEVICE_TABLE(i2c, ov5642_id);
+#if IS_ENABLED(CONFIG_OF)
+static const struct of_device_id ov5642_of_match[] = {
+ { .compatible = "ovti,ov5642" },
+ { },
+};
+MODULE_DEVICE_TABLE(of, ov5642_of_match);
+#endif
+
static struct i2c_driver ov5642_i2c_driver = {
.driver = {
.name = "ov5642",
+ .of_match_table = of_match_ptr(ov5642_of_match),
},
.probe = ov5642_probe,
.remove = ov5642_remove,
--
2.9.3
[toc] | [next] | [standalone]
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2017-02-22 17:30 +0100 |
| Subject | [PATCH 2/3] [media] tc358743: Add OF device ID table |
| Message-ID | <tdHXH-4rY-7@gated-at.bofh.it> |
| In reply to | #1586294 |
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/media/i2c/tc358743.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index f569a05fe105..76baf7a7bd57 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
@@ -1951,9 +1951,18 @@ static struct i2c_device_id tc358743_id[] = {
MODULE_DEVICE_TABLE(i2c, tc358743_id);
+#if IS_ENABLED(CONFIG_OF)
+static const struct of_device_id tc358743_of_match[] = {
+ { .compatible = "toshiba,tc358743" },
+ {},
+};
+MODULE_DEVICE_TABLE(of, tc358743_of_match);
+#endif
+
static struct i2c_driver tc358743_driver = {
.driver = {
.name = "tc358743",
+ .of_match_table = of_match_ptr(tc358743_of_match),
},
.probe = tc358743_probe,
.remove = tc358743_remove,
--
2.9.3
[toc] | [prev] | [next] | [standalone]
| From | "Mats Randgaard (matrandg)" <matrandg@cisco.com> |
|---|---|
| Date | 2017-02-22 21:30 +0100 |
| Subject | Re: [PATCH 2/3] [media] tc358743: Add OF device ID table |
| Message-ID | <tdLHY-7aV-9@gated-at.bofh.it> |
| In reply to | #1586295 |
CC: Philipp Zabel who added device tree support to this driver
Regards,
Mats Randgaard
On 02/22/2017 05:11 PM, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/media/i2c/tc358743.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
> index f569a05fe105..76baf7a7bd57 100644
> --- a/drivers/media/i2c/tc358743.c
> +++ b/drivers/media/i2c/tc358743.c
> @@ -1951,9 +1951,18 @@ static struct i2c_device_id tc358743_id[] = {
>
> MODULE_DEVICE_TABLE(i2c, tc358743_id);
>
> +#if IS_ENABLED(CONFIG_OF)
> +static const struct of_device_id tc358743_of_match[] = {
> + { .compatible = "toshiba,tc358743" },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, tc358743_of_match);
> +#endif
> +
> static struct i2c_driver tc358743_driver = {
> .driver = {
> .name = "tc358743",
> + .of_match_table = of_match_ptr(tc358743_of_match),
> },
> .probe = tc358743_probe,
> .remove = tc358743_remove,
[toc] | [prev] | [next] | [standalone]
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Date | 2017-02-22 17:30 +0100 |
| Subject | [PATCH 3/3] [media] si4713: Add OF device ID table |
| Message-ID | <tdHXH-4rY-17@gated-at.bofh.it> |
| In reply to | #1586294 |
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/media/radio/si4713/si4713.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/media/radio/si4713/si4713.c b/drivers/media/radio/si4713/si4713.c
index 60f026a58076..f4a53f1e856e 100644
--- a/drivers/media/radio/si4713/si4713.c
+++ b/drivers/media/radio/si4713/si4713.c
@@ -1656,9 +1656,18 @@ static const struct i2c_device_id si4713_id[] = {
};
MODULE_DEVICE_TABLE(i2c, si4713_id);
+#if IS_ENABLED(CONFIG_OF)
+static const struct of_device_id si4713_of_match[] = {
+ { .compatible = "silabs,si4713" },
+ { },
+};
+MODULE_DEVICE_TABLE(of, si4713_of_match);
+#endif
+
static struct i2c_driver si4713_i2c_driver = {
.driver = {
.name = "si4713",
+ .of_match_table = of_match_ptr(si4713_of_match),
},
.probe = si4713_probe,
.remove = si4713_remove,
--
2.9.3
[toc] | [prev] | [next] | [standalone]
| From | Guennadi Liakhovetski <g.liakhovetski@gmx.de> |
|---|---|
| Date | 2017-02-26 21:00 +0100 |
| Message-ID | <tfd98-2SY-15@gated-at.bofh.it> |
| In reply to | #1586294 |
On Wed, 22 Feb 2017, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> drivers/media/i2c/soc_camera/ov5642.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/i2c/soc_camera/ov5642.c b/drivers/media/i2c/soc_camera/ov5642.c
> index 3d185bd622a3..1926f382dfce 100644
> --- a/drivers/media/i2c/soc_camera/ov5642.c
> +++ b/drivers/media/i2c/soc_camera/ov5642.c
> @@ -1063,9 +1063,18 @@ static const struct i2c_device_id ov5642_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, ov5642_id);
>
> +#if IS_ENABLED(CONFIG_OF)
> +static const struct of_device_id ov5642_of_match[] = {
> + { .compatible = "ovti,ov5642" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, ov5642_of_match);
> +#endif
> +
> static struct i2c_driver ov5642_i2c_driver = {
> .driver = {
> .name = "ov5642",
> + .of_match_table = of_match_ptr(ov5642_of_match),
> },
> .probe = ov5642_probe,
> .remove = ov5642_remove,
> --
> 2.9.3
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web