Re: [PATCH 2/4] fs, afs: convert afs_vlocation.usage from atomic_t to refcount_t

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] fs, afs: convert afs_vlocation.usage from atomic_t to refcount_t
Date	2017-02-22 17:30 +0100
Message-ID	<tdHXH-4rY-13@gated-at.bofh.it> (permalink)
References	<tdkRs-4uK-29@gated-at.bofh.it> <tdkRr-4uK-13@gated-at.bofh.it> <tdkRs-4uK-29@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Elena Reshetova <elena.reshetova@intel.com> wrote:

> refcount_t type and corresponding API should be
> used instead of atomic_t when the variable is used as
> a reference counter. This allows to avoid accidental
> refcounter overflows that might lead to use-after-free
> situations.

Please hold this patch also.  An assertion failure may happen here too because
afs_vlocation_lookup() may resurrect records with a refcount of 0 from the
cache.

David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] fs, afs: convert afs_vlocation.usage from atomic_t to refcount_t Elena Reshetova <elena.reshetova@intel.com> - 2017-02-21 16:50 +0100
  Re: [PATCH 2/4] fs, afs: convert afs_vlocation.usage from atomic_t to refcount_t David Howells <dhowells@redhat.com> - 2017-02-22 17:30 +0100

csiph-web