Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1586295
| From | Javier Martinez Canillas <javier@osg.samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/3] [media] tc358743: Add OF device ID table |
| Date | 2017-02-22 17:30 +0100 |
| Message-ID | <tdHXH-4rY-7@gated-at.bofh.it> (permalink) |
| References | <tdHXH-4rY-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/media/i2c/tc358743.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index f569a05fe105..76baf7a7bd57 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
@@ -1951,9 +1951,18 @@ static struct i2c_device_id tc358743_id[] = {
MODULE_DEVICE_TABLE(i2c, tc358743_id);
+#if IS_ENABLED(CONFIG_OF)
+static const struct of_device_id tc358743_of_match[] = {
+ { .compatible = "toshiba,tc358743" },
+ {},
+};
+MODULE_DEVICE_TABLE(of, tc358743_of_match);
+#endif
+
static struct i2c_driver tc358743_driver = {
.driver = {
.name = "tc358743",
+ .of_match_table = of_match_ptr(tc358743_of_match),
},
.probe = tc358743_probe,
.remove = tc358743_remove,
--
2.9.3
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-22 17:30 +0100
[PATCH 2/3] [media] tc358743: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-22 17:30 +0100
Re: [PATCH 2/3] [media] tc358743: Add OF device ID table "Mats Randgaard (matrandg)" <matrandg@cisco.com> - 2017-02-22 21:30 +0100
[PATCH 3/3] [media] si4713: Add OF device ID table Javier Martinez Canillas <javier@osg.samsung.com> - 2017-02-22 17:30 +0100
Re: [PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table Guennadi Liakhovetski <g.liakhovetski@gmx.de> - 2017-02-26 21:00 +0100
csiph-web