Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1654515

Re: [PATCH v3 5/6] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses

Show all headers | View raw

On Tue, May 30, 2017 at 10:33 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> Avoids reimplementation of DMI matching in stmmac_pci_find_phy_addr.

>  struct stmmac_pci_dmi_data {
> -       const char *name;
> -       const char *asset_tag;
> -       unsigned int func;
> +       int func;
>         int phy_addr;
>  };

Can we use the following instead:

struct stmmac_pci_dmi_data {
       unsigned int *func;
       int *phy_addr;
       size_t nfuncs;
};

or something like

struct stmmac_pci_func_data {
       unsigned int func;
       int phy_addr;
};

struct stmmac_pci_dmi_data {
    struct stmmac_pci_func_data *func;
    size_t nfuncs;
};

(Latter would be better since it allows to use ARRAY_SIZE() and less
error prone for possible asymmetrical amount of values in the former)

?

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/6] stmmac: pci: Refactor DMI probing Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  [PATCH v3 5/6] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
    Re: [PATCH v3 5/6] stmmac: pci: Use dmi_system_id table for  retrieving PHY addresses Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-31 20:10 +0200
  [PATCH v3 3/6] stmmac: pci: Make stmmac_pci_find_phy_addr truly generic Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  [PATCH v3 2/6] stmmac: pci: Use stmmac_pci_info for all devices Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  [PATCH v3 4/6] stmmac: pci: Select quark_pci_dmi_data from quark_default_data Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  [PATCH v3 6/6] stmmac: pci: Remove setup handler indirection via stmmac_pci_info Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  [PATCH v3 1/6] stmmac: pci: Make stmmac_pci_info structure constant Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  Re: [PATCH v3 0/6] stmmac: pci: Refactor DMI probing Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-30 20:50 +0200
    Re: [PATCH v3 0/6] stmmac: pci: Refactor DMI probing David Miller <davem@davemloft.net> - 2017-05-31 18:40 +0200

csiph-web