Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1653484

Re: [PATCH v3 0/6] stmmac: pci: Refactor DMI probing

Show all headers | View raw

On Tue, May 30, 2017 at 10:33 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> Some cleanups of the way we probe DMI platforms in the driver. Reduces
> a bit of open-coding and makes the logic easier reusable for any
> potential DMI platform != Quark.
>
> Tested on IOT2000 and Galileo Gen2.

So, for patches 1-4,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

I'm not convinced that patch 6 is needed, so, my vote is not to include it.

Patch 5 I would like to review later. Main problem to me is {-1, -1}.
It looks non-standard and feels not good. I'll try to think on the
solution.

> Jan Kiszka (6):
>   stmmac: pci: Make stmmac_pci_info structure constant
>   stmmac: pci: Use stmmac_pci_info for all devices
>   stmmac: pci: Make stmmac_pci_find_phy_addr truly generic
>   stmmac: pci: Select quark_pci_dmi_data from quark_default_data
>   stmmac: pci: Use dmi_system_id table for retrieving PHY addresses
>   stmmac: pci: Remove setup handler indirection via stmmac_pci_info

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/6] stmmac: pci: Refactor DMI probing Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  [PATCH v3 5/6] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
    Re: [PATCH v3 5/6] stmmac: pci: Use dmi_system_id table for  retrieving PHY addresses Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-31 20:10 +0200
  [PATCH v3 3/6] stmmac: pci: Make stmmac_pci_find_phy_addr truly generic Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  [PATCH v3 2/6] stmmac: pci: Use stmmac_pci_info for all devices Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  [PATCH v3 4/6] stmmac: pci: Select quark_pci_dmi_data from quark_default_data Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  [PATCH v3 6/6] stmmac: pci: Remove setup handler indirection via stmmac_pci_info Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  [PATCH v3 1/6] stmmac: pci: Make stmmac_pci_info structure constant Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  Re: [PATCH v3 0/6] stmmac: pci: Refactor DMI probing Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-30 20:50 +0200
    Re: [PATCH v3 0/6] stmmac: pci: Refactor DMI probing David Miller <davem@davemloft.net> - 2017-05-31 18:40 +0200

csiph-web