Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1654514

Re: [PATCH v3 2/4] Documentation: dt: iio: at91-sama5d2_adc: add adtrg trigger binding

Show all headers | View raw

On Thu, May 25, 2017 at 02:17:12PM +0300, Eugen Hristev wrote:
> Add node information for ADTRG hardware pin and the three possible
> edge nodes that are available for the driver
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
>  .../devicetree/bindings/iio/adc/at91-sama5d2_adc.txt    | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> index 3223684..e30ede3 100644
> --- a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> @@ -11,6 +11,13 @@ Required properties:
>    - atmel,min-sample-rate-hz: Minimum sampling rate, it depends on SoC.
>    - atmel,max-sample-rate-hz: Maximum sampling rate, it depends on SoC.
>    - atmel,startup-time-ms: Startup time expressed in ms, it depends on SoC.
> +  - atmel,trigger-edge-type: phandle to one of the adtrg possible edge types
> +
> +Required adtrg node:
> +  - Required edge nodes:
> +	For each possible edge type for the ADTRG hardware trigger pin,
> +	 a specific sub node. The driver recognises only the three possible
> +	 edge types: external_rising, external_falling, external_any.

Why is this not just a simple property? Having 4 nodes just for this is 
pointless.

>  
>  Example:
>  
> @@ -25,4 +32,14 @@ adc: adc@fc030000 {
>  	atmel,startup-time-ms = <4>;
>  	vddana-supply = <&vdd_3v3_lp_reg>;
>  	vref-supply = <&vdd_3v3_lp_reg>;
> +	atmel,trigger-edge-type = <&external_rising>;
> +
> +	adtrg: adtrg {
> +		external_rising: external_rising {
> +		};
> +		external_falling: external_falling {
> +		};
> +		external_any: external_any {
> +		};
> +	};
>  }
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/4] iio: adc: sama5d2_adc hw triggers and buffers Eugen Hristev <eugen.hristev@microchip.com> - 2017-05-25 13:30 +0200
  [PATCH v3 3/4] ARM: dts: at91: sama5d2: add ADC hw trigger Eugen Hristev <eugen.hristev@microchip.com> - 2017-05-25 13:30 +0200
  [PATCH v3 2/4] Documentation: dt: iio: at91-sama5d2_adc: add adtrg trigger binding Eugen Hristev <eugen.hristev@microchip.com> - 2017-05-25 13:30 +0200
    Re: [PATCH v3 2/4] Documentation: dt: iio: at91-sama5d2_adc: add  adtrg trigger binding Jonathan Cameron <jic23@kernel.org> - 2017-05-28 17:30 +0200
    Re: [PATCH v3 2/4] Documentation: dt: iio: at91-sama5d2_adc: add  adtrg trigger binding Rob Herring <robh@kernel.org> - 2017-05-31 20:10 +0200
  [PATCH v3 4/4] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support Eugen Hristev <eugen.hristev@microchip.com> - 2017-05-25 13:30 +0200
    Re: [PATCH v3 4/4] iio: adc: at91-sama5d2_adc: add hw trigger and  buffer support Jonathan Cameron <jic23@kernel.org> - 2017-05-28 17:30 +0200
  [PATCH v3 1/4] ARM: dts: at91: sama5d2_xplained: enable ADTRG pin Eugen Hristev <eugen.hristev@microchip.com> - 2017-05-25 13:30 +0200

csiph-web