Re: [PATCH v3 0/6] stmmac: pci: Refactor DMI probing

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 0/6] stmmac: pci: Refactor DMI probing
Date	2017-05-31 18:40 +0200
Message-ID	<tNeP8-7dL-11@gated-at.bofh.it> (permalink)
References	<tMJUZ-4hz-3@gated-at.bofh.it> <tMUnn-2tM-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Tue, 30 May 2017 21:48:05 +0300

> On Tue, May 30, 2017 at 10:33 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> Some cleanups of the way we probe DMI platforms in the driver. Reduces
>> a bit of open-coding and makes the logic easier reusable for any
>> potential DMI platform != Quark.
>>
>> Tested on IOT2000 and Galileo Gen2.
> 
> So, for patches 1-4,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
> I'm not convinced that patch 6 is needed, so, my vote is not to include it.
> 
> Patch 5 I would like to review later. Main problem to me is {-1, -1}.
> It looks non-standard and feels not good. I'll try to think on the
> solution.

Ok, so at a minimum I'm expecting another respin of this.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/6] stmmac: pci: Refactor DMI probing Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  [PATCH v3 5/6] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
    Re: [PATCH v3 5/6] stmmac: pci: Use dmi_system_id table for  retrieving PHY addresses Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-31 20:10 +0200
  [PATCH v3 3/6] stmmac: pci: Make stmmac_pci_find_phy_addr truly generic Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  [PATCH v3 2/6] stmmac: pci: Use stmmac_pci_info for all devices Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  [PATCH v3 4/6] stmmac: pci: Select quark_pci_dmi_data from quark_default_data Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  [PATCH v3 6/6] stmmac: pci: Remove setup handler indirection via stmmac_pci_info Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  [PATCH v3 1/6] stmmac: pci: Make stmmac_pci_info structure constant Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-30 09:40 +0200
  Re: [PATCH v3 0/6] stmmac: pci: Refactor DMI probing Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-30 20:50 +0200
    Re: [PATCH v3 0/6] stmmac: pci: Refactor DMI probing David Miller <davem@davemloft.net> - 2017-05-31 18:40 +0200

csiph-web