Re: [PATCH net-next] net: dsa: remove dev arg of dsa_register_switch

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] net: dsa: remove dev arg of dsa_register_switch
Date	2017-05-31 18:40 +0200
Message-ID	<tNeP8-7dL-15@gated-at.bofh.it> (permalink)
References	<tLyIl-4Vw-107@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Fri, 26 May 2017 18:12:51 -0400

> The current dsa_register_switch function takes a useless struct device
> pointer argument, which always equals ds->dev.
> 
> Drivers either call it with ds->dev, or with the same device pointer
> passed to dsa_switch_alloc, which ends up being assigned to ds->dev.
> 
> This patch removes the second argument of the dsa_register_switch and
> _dsa_register_switch functions.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Those invariants seem to hold indeed, so this looks fine, applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net: dsa: remove dev arg of dsa_register_switch Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-27 03:30 +0200
  Re: [PATCH net-next] net: dsa: remove dev arg of  dsa_register_switch David Miller <davem@davemloft.net> - 2017-05-31 18:40 +0200

csiph-web