Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1653878
| From | "Chen, Xiaoguang" <xiaoguang.chen@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g |
| Date | 2017-05-31 08:50 +0200 |
| Message-ID | <tN5C9-1gO-1@gated-at.bofh.it> (permalink) |
| References | <tLFA5-QN-3@gated-at.bofh.it> <tLFA6-QN-15@gated-at.bofh.it> <tN3TH-6e-3@gated-at.bofh.it> <tN5iO-1a0-11@gated-at.bofh.it> <tN5st-1db-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
>-----Original Message-----
>From: Zhenyu Wang [mailto:zhenyuw@linux.intel.com]
>Sent: Wednesday, May 31, 2017 2:30 PM
>To: Chen, Xiaoguang <xiaoguang.chen@intel.com>
>Cc: Tian, Kevin <kevin.tian@intel.com>; intel-gfx@lists.freedesktop.org; linux-
>kernel@vger.kernel.org; chris@chris-wilson.co.uk; alex.williamson@redhat.com;
>kraxel@redhat.com; Niu, Bing <bing.niu@intel.com>; intel-gvt-
>dev@lists.freedesktop.org; Wang, Zhi A <zhi.a.wang@intel.com>; Lv, Zhiyuan
><zhiyuan.lv@intel.com>
>Subject: Re: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g
>
>On 2017.05.31 06:22:28 +0000, Chen, Xiaoguang wrote:
>> >> @@ -467,6 +555,15 @@ static int intel_vgpu_create(struct kobject
>> >> *kobj,
>> >struct mdev_device *mdev)
>> >> vgpu->vdev.mdev = mdev;
>> >> mdev_set_drvdata(mdev, vgpu);
>> >>
>> >> + ret = intel_vgpu_reg_init_opregion(vgpu);
>> >> + if (ret) {
>> >> + gvt_vgpu_err("create OpRegion failed\n");
>> >> + goto out;
>> >> + }
>> >
>> >Still need to handle error path for created vgpu.
>> Just checked the code, if initialize the opregion failed we should first release
>vfio/mdev releated work(maybe call intel_vgpu_release function) and then
>destroy the vgpu. Will update in the next version.
>>
>
>Better to init opregion inside of create vgpu and do proper error handling there
>too.
Then we must add a new entry in intel_gvt_mpt interface something like "create_opregion".
>
>--
>Open Source Technology Center, Intel ltd.
>
>$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g Xiaoguang Chen <xiaoguang.chen@intel.com> - 2017-05-27 10:50 +0200
[PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g Xiaoguang Chen <xiaoguang.chen@intel.com> - 2017-05-27 10:50 +0200
Re: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g Zhenyu Wang <zhenyuw@linux.intel.com> - 2017-05-31 07:00 +0200
RE: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g "Chen, Xiaoguang" <xiaoguang.chen@intel.com> - 2017-05-31 08:30 +0200
Re: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g Zhenyu Wang <zhenyuw@linux.intel.com> - 2017-05-31 08:40 +0200
RE: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g "Chen, Xiaoguang" <xiaoguang.chen@intel.com> - 2017-05-31 08:50 +0200
[PATCH v6 5/6] drm/i915/gvt: Dmabuf support for GVT-g Xiaoguang Chen <xiaoguang.chen@intel.com> - 2017-05-27 10:50 +0200
Re: [PATCH v6 5/6] drm/i915/gvt: Dmabuf support for GVT-g Gerd Hoffmann <kraxel@redhat.com> - 2017-05-31 14:10 +0200
RE: [PATCH v6 5/6] drm/i915/gvt: Dmabuf support for GVT-g "Chen, Xiaoguang" <xiaoguang.chen@intel.com> - 2017-06-01 05:10 +0200
Re: [PATCH v6 5/6] drm/i915/gvt: Dmabuf support for GVT-g Chris Wilson <chris@chris-wilson.co.uk> - 2017-06-01 11:20 +0200
[PATCH v6 1/6] drm/i915/gvt: Extend the GVT-g architecture to support vfio device region Xiaoguang Chen <xiaoguang.chen@intel.com> - 2017-05-27 10:50 +0200
[PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Xiaoguang Chen <xiaoguang.chen@intel.com> - 2017-05-27 10:50 +0200
Re: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-05-29 09:30 +0200
RE: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations "Chen, Xiaoguang" <xiaoguang.chen@intel.com> - 2017-05-31 08:20 +0200
Re: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Kirti Wankhede <kwankhede@nvidia.com> - 2017-05-31 19:30 +0200
RE: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations "Chen, Xiaoguang" <xiaoguang.chen@intel.com> - 2017-06-01 05:10 +0200
Re: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Alex Williamson <alex.williamson@redhat.com> - 2017-06-01 18:40 +0200
Re: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Kirti Wankhede <kwankhede@nvidia.com> - 2017-06-01 20:50 +0200
Re: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-06-02 10:40 +0200
Re: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Kirti Wankhede <kwankhede@nvidia.com> - 2017-06-05 10:30 +0200
Re: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-06-06 10:00 +0200
Re: [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g Gerd Hoffmann <kraxel@redhat.com> - 2017-05-30 12:30 +0200
RE: [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g "Chen, Xiaoguang" <xiaoguang.chen@intel.com> - 2017-05-31 04:30 +0200
Re: [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g Gerd Hoffmann <kraxel@redhat.com> - 2017-05-31 11:00 +0200
RE: [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g "Chen, Xiaoguang" <xiaoguang.chen@intel.com> - 2017-05-31 11:10 +0200
csiph-web