Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1654028

RE: [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g

Show all headers | View raw

Hi Gerd,

I found this problem once I sent the patches :(

I checked the uapi definitions and found it is usually called pad to do the aligning. So I changed the 'resv' to 'pad' in the patch but forgot to update it in the last patch and did not test after the "small" change. Next time I will test even when the change is very small.

I will change this in the next version.
Sorry for the mistake.

>-----Original Message-----
>From: Gerd Hoffmann [mailto:kraxel@redhat.com]
>Sent: Wednesday, May 31, 2017 4:59 PM
>To: Chen, Xiaoguang <xiaoguang.chen@intel.com>;
>alex.williamson@redhat.com; chris@chris-wilson.co.uk; intel-
>gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org;
>zhenyuw@linux.intel.com; Lv, Zhiyuan <zhiyuan.lv@intel.com>; intel-gvt-
>dev@lists.freedesktop.org; Wang, Zhi A <zhi.a.wang@intel.com>; Tian, Kevin
><kevin.tian@intel.com>
>Subject: Re: [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g
>
>On Wed, 2017-05-31 at 02:29 +0000, Chen, Xiaoguang wrote:
>> Hi Gerd,
>>
>> It is based on 4.12.0-rc1
>
>Applies, good.
>But then fails to build:
>
>error: ‘struct vfio_vgpu_dmabuf_info’ has no member named ‘resv’
>
>gvt/kvmgt.c:611:11: note: in expansion of macro ‘offsetofend’
>   minsz = offsetofend(struct vfio_vgpu_dmabuf_info, resv);
>
>/me wonders how this was tested ...
>
>cheers,
>  Gerd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g Xiaoguang Chen <xiaoguang.chen@intel.com> - 2017-05-27 10:50 +0200
  [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g Xiaoguang Chen <xiaoguang.chen@intel.com> - 2017-05-27 10:50 +0200
    Re: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g Zhenyu Wang <zhenyuw@linux.intel.com> - 2017-05-31 07:00 +0200
      RE: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g "Chen, Xiaoguang" <xiaoguang.chen@intel.com> - 2017-05-31 08:30 +0200
        Re: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g Zhenyu Wang <zhenyuw@linux.intel.com> - 2017-05-31 08:40 +0200
          RE: [PATCH v6 2/6] drm/i915/gvt: OpRegion support for GVT-g "Chen, Xiaoguang" <xiaoguang.chen@intel.com> - 2017-05-31 08:50 +0200
  [PATCH v6 5/6] drm/i915/gvt: Dmabuf support for GVT-g Xiaoguang Chen <xiaoguang.chen@intel.com> - 2017-05-27 10:50 +0200
    Re: [PATCH v6 5/6] drm/i915/gvt: Dmabuf support for GVT-g Gerd Hoffmann <kraxel@redhat.com> - 2017-05-31 14:10 +0200
      RE: [PATCH v6 5/6] drm/i915/gvt: Dmabuf support for GVT-g "Chen, Xiaoguang" <xiaoguang.chen@intel.com> - 2017-06-01 05:10 +0200
    Re: [PATCH v6 5/6] drm/i915/gvt: Dmabuf support for GVT-g Chris Wilson <chris@chris-wilson.co.uk> - 2017-06-01 11:20 +0200
  [PATCH v6 1/6] drm/i915/gvt: Extend the GVT-g architecture to support vfio device region Xiaoguang Chen <xiaoguang.chen@intel.com> - 2017-05-27 10:50 +0200
  [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Xiaoguang Chen <xiaoguang.chen@intel.com> - 2017-05-27 10:50 +0200
    Re: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-05-29 09:30 +0200
      RE: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations "Chen, Xiaoguang" <xiaoguang.chen@intel.com> - 2017-05-31 08:20 +0200
        Re: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Kirti Wankhede <kwankhede@nvidia.com> - 2017-05-31 19:30 +0200
          RE: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations "Chen, Xiaoguang" <xiaoguang.chen@intel.com> - 2017-06-01 05:10 +0200
            Re: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf  operations Alex Williamson <alex.williamson@redhat.com> - 2017-06-01 18:40 +0200
              Re: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Kirti Wankhede <kwankhede@nvidia.com> - 2017-06-01 20:50 +0200
                Re: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-06-02 10:40 +0200
                Re: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Kirti Wankhede <kwankhede@nvidia.com> - 2017-06-05 10:30 +0200
                Re: [PATCH v6 4/6] vfio: Define vfio based vgpu's dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-06-06 10:00 +0200
  Re: [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g Gerd Hoffmann <kraxel@redhat.com> - 2017-05-30 12:30 +0200
    RE: [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g "Chen, Xiaoguang" <xiaoguang.chen@intel.com> - 2017-05-31 04:30 +0200
      Re: [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g Gerd Hoffmann <kraxel@redhat.com> - 2017-05-31 11:00 +0200
        RE: [PATCH v6 0/6] drm/i915/gvt: Dma-buf support for GVT-g "Chen, Xiaoguang" <xiaoguang.chen@intel.com> - 2017-05-31 11:10 +0200

csiph-web