Re: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support

From	Dong Aisheng <dongas86@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support
Date	2017-05-31 08:40 +0200
Message-ID	<tN5su-1db-15@gated-at.bofh.it> (permalink)
References	<tIETU-39a-15@gated-at.bofh.it> <tL81r-4EH-3@gated-at.bofh.it> <tL81r-4EH-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Daniel,

On Thu, May 25, 2017 at 10:54:55PM +0200, Daniel Lezcano wrote:
> On Sat, May 13, 2017 at 03:29:35PM +0800, Dong Aisheng wrote:
> > IMX Timer/PWM Module (TPM) supports both timer and pwm function while
> > this patch only adds the timer support. PWM would be added later.
> > 
> > The TPM counter, compare and capture registers are clocked by an
> > asynchronous clock that can remain enabled in low power modes.
> > 
> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > Signed-off-by: Bai Ping <ping.bai@nxp.com>
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> 
> [ ... ]
> 
> > +	val = __raw_readl(timer_base + TPM_C0SC);
> > +	val &= ~(TPM_C0SC_MODE_MASK | TPM_C0SC_CHIE);
> > +	__raw_writel(val, timer_base + TPM_C0SC);
> 
> Hi Dong,
> 
> why are you using __raw_write/__raw_read instead of regular readl/writel?
> 

Sorry for missing the second throught of it.

Will change to readl/writel as Arnd pointed out in another mail.

Regards
Dong Aisheng

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support Daniel Lezcano <daniel.lezcano@linaro.org> - 2017-05-25 23:00 +0200
  Re: [PATCH 2/2] timer: imx-tpm: add imx tpm timer support Dong Aisheng <dongas86@gmail.com> - 2017-05-31 08:40 +0200

csiph-web