Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1647258

Re: [PATCH net] bonding: fix randomly populated arp target array

Show all headers | View raw

From: Jarod Wilson <jarod@redhat.com>
Date: Fri, 19 May 2017 14:46:46 -0400

> In commit dc9c4d0fe023, the arp_target array moved from a static global
> to a local variable. By the nature of static globals, the array used to
> be initialized to all 0. At present, it's full of random data, which
> that gets interpreted as arp_target values, when none have actually been
> specified. Systems end up booting with spew along these lines:
 ...
> None of these were actually specified as ARP targets, and the driver does
> seem to clean up the mess okay, but it's rather noisy and confusing, leaks
> values to userspace, and the 255.255.255.255 spew shows up even when debug
> prints are disabled.
> 
> The fix: just zero out arp_target at init time.
> 
> While we're in here, init arp_all_targets_value in the right place.
> 
> Fixes: dc9c4d0fe023 ("bonding: reduce scope of some global variables")
> CC: Mahesh Bandewar <maheshb@google.com>
> CC: Jay Vosburgh <j.vosburgh@gmail.com>
> CC: Veaceslav Falico <vfalico@gmail.com>
> CC: Andy Gospodarek <andy@greyhouse.net>
> CC: netdev@vger.kernel.org
> CC: stable@vger.kernel.org
> Signed-off-by: Jarod Wilson <jarod@redhat.com>

Whoops... applied, thanks Jarod.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net] bonding: fix randomly populated arp target array Jarod Wilson <jarod@redhat.com> - 2017-05-19 20:50 +0200
  Re: [PATCH net] bonding: fix randomly populated arp target array Andy Gospodarek <andy@greyhouse.net> - 2017-05-19 21:30 +0200
  Re: [PATCH net] bonding: fix randomly populated arp target array Mahesh Bandewar (महेश बंडेवार)          <maheshb@google.com> - 2017-05-19 22:40 +0200
    Re: [PATCH net] bonding: fix randomly populated arp target array Jarod Wilson <jarod@redhat.com> - 2017-05-20 00:20 +0200
  Re: [PATCH net] bonding: fix randomly populated arp target array David Miller <davem@davemloft.net> - 2017-05-22 20:40 +0200

csiph-web