Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1633039
| From | Al Viro <viro@ZenIV.linux.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: iov_iter_pipe warning. |
| Date | 2017-04-28 19:30 +0200 |
| Message-ID | <tBhSp-272-3@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <tvvOq-8oz-17@gated-at.bofh.it> <tyM6m-1aE-23@gated-at.bofh.it> <tBg9X-Qc-1@gated-at.bofh.it> <tBhfH-1AI-15@gated-at.bofh.it> <tBhpn-1F2-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Apr 28, 2017 at 12:50:24PM -0400, Dave Jones wrote:
> currently running v4.11-rc8-75-gf83246089ca0
>
> sunrpc bit is for the other unrelated problem I'm chasing.
>
> note also, I saw the backtrace without the fs/splice.c changes.
Interesting... Could you add this and see if that triggers?
diff --git a/fs/splice.c b/fs/splice.c
index 540c4a44756c..12a12d9c313f 100644
--- a/fs/splice.c
+++ b/fs/splice.c
@@ -306,6 +306,9 @@ ssize_t generic_file_splice_read(struct file *in, loff_t *ppos,
kiocb.ki_pos = *ppos;
ret = call_read_iter(in, &kiocb, &to);
if (ret > 0) {
+ if (WARN_ON(iov_iter_count(&to) != len - ret))
+ printk(KERN_ERR "ops %p: was %zd, left %zd, returned %d\n",
+ in->f_op, len, iov_iter_count(&to), ret);
*ppos = kiocb.ki_pos;
file_accessed(in);
} else if (ret < 0) {
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: iov_iter_pipe warning. Dave Jones <davej@codemonkey.org.uk> - 2017-04-28 17:40 +0200
Re: iov_iter_pipe warning. Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-28 18:50 +0200
Re: iov_iter_pipe warning. Dave Jones <davej@codemonkey.org.uk> - 2017-04-28 19:00 +0200
Re: iov_iter_pipe warning. Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-28 19:30 +0200
Re: iov_iter_pipe warning. Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-28 20:30 +0200
Re: iov_iter_pipe warning. Dave Jones <davej@codemonkey.org.uk> - 2017-04-29 04:00 +0200
Re: iov_iter_pipe warning. Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-29 04:50 +0200
Re: iov_iter_pipe warning. Dave Jones <davej@codemonkey.org.uk> - 2017-04-29 18:00 +0200
[git pull] vfs.git fix (Re: iov_iter_pipe warning.) Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-29 22:50 +0200
csiph-web