Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1633078
| From | Al Viro <viro@ZenIV.linux.org.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: iov_iter_pipe warning. |
| Date | 2017-04-28 20:30 +0200 |
| Message-ID | <tBiOt-2Nu-7@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <tyM6m-1aE-23@gated-at.bofh.it> <tBg9X-Qc-1@gated-at.bofh.it> <tBhfH-1AI-15@gated-at.bofh.it> <tBhpn-1F2-1@gated-at.bofh.it> <tBhSp-272-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Apr 28, 2017 at 06:20:25PM +0100, Al Viro wrote:
> On Fri, Apr 28, 2017 at 12:50:24PM -0400, Dave Jones wrote:
> > currently running v4.11-rc8-75-gf83246089ca0
> >
> > sunrpc bit is for the other unrelated problem I'm chasing.
> >
> > note also, I saw the backtrace without the fs/splice.c changes.
>
> Interesting... Could you add this and see if that triggers?
Gyah... It's a bloody dumb braino in iov_iter_revert() for pipe-backed
ones. Sorry, the oneliner below should fix it.
diff --git a/lib/iov_iter.c b/lib/iov_iter.c
index f7c93568ec99..4952311422c1 100644
--- a/lib/iov_iter.c
+++ b/lib/iov_iter.c
@@ -798,7 +798,7 @@ void iov_iter_revert(struct iov_iter *i, size_t unroll)
while (1) {
size_t n = off - pipe->bufs[idx].offset;
if (unroll < n) {
- off -= (n - unroll);
+ off -= unroll;
break;
}
unroll -= n;
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: iov_iter_pipe warning. Dave Jones <davej@codemonkey.org.uk> - 2017-04-28 17:40 +0200
Re: iov_iter_pipe warning. Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-28 18:50 +0200
Re: iov_iter_pipe warning. Dave Jones <davej@codemonkey.org.uk> - 2017-04-28 19:00 +0200
Re: iov_iter_pipe warning. Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-28 19:30 +0200
Re: iov_iter_pipe warning. Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-28 20:30 +0200
Re: iov_iter_pipe warning. Dave Jones <davej@codemonkey.org.uk> - 2017-04-29 04:00 +0200
Re: iov_iter_pipe warning. Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-29 04:50 +0200
Re: iov_iter_pipe warning. Dave Jones <davej@codemonkey.org.uk> - 2017-04-29 18:00 +0200
[git pull] vfs.git fix (Re: iov_iter_pipe warning.) Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-29 22:50 +0200
csiph-web