Re: iov_iter_pipe warning.

From	Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: iov_iter_pipe warning.
Date	2017-04-28 18:50 +0200
Message-ID	<tBhfH-1AI-15@gated-at.bofh.it> (permalink)
References	(5 earlier) <tvtjA-6IX-15@gated-at.bofh.it> <tvtWi-7dn-21@gated-at.bofh.it> <tvvOq-8oz-17@gated-at.bofh.it> <tyM6m-1aE-23@gated-at.bofh.it> <tBg9X-Qc-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 28, 2017 at 11:29:55AM -0400, Dave Jones wrote:
> On Fri, Apr 21, 2017 at 06:54:30PM +0100, Al Viro wrote:
>  > On Wed, Apr 12, 2017 at 03:03:18PM -0400, Dave Jones wrote:
>  > 
>  > > Well it's been running an hour without incident, which looks promising.
>  > > I'll leave it run, but I'd say you're on the right track given how quick
>  > > it reproduced so far.
>  > 
>  > Could you try this and see if it works?  What happens is that unlike
>  > e.g. generic_file_read_iter/generic_file_write_iter, NFS O_DIRECT handling
>  > does not make sure that iov_iter had been advanced by the amount
>  > actually transferred - it is left advanced by the amount *requested*.
> 
> Crap. So I never ran it long enough it seems. I can still hit that trace.
> I re-added one of your earlier debug patches, and got this..

Could you send me the diff against something from mainline (identified by
sha1, ideally)?

Thread

Re: iov_iter_pipe warning. Dave Jones <davej@codemonkey.org.uk> - 2017-04-28 17:40 +0200
  Re: iov_iter_pipe warning. Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-28 18:50 +0200
    Re: iov_iter_pipe warning. Dave Jones <davej@codemonkey.org.uk> - 2017-04-28 19:00 +0200
      Re: iov_iter_pipe warning. Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-28 19:30 +0200
        Re: iov_iter_pipe warning. Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-28 20:30 +0200
          Re: iov_iter_pipe warning. Dave Jones <davej@codemonkey.org.uk> - 2017-04-29 04:00 +0200
            Re: iov_iter_pipe warning. Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-29 04:50 +0200
              Re: iov_iter_pipe warning. Dave Jones <davej@codemonkey.org.uk> - 2017-04-29 18:00 +0200
                [git pull] vfs.git fix (Re: iov_iter_pipe warning.) Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-29 22:50 +0200

csiph-web