Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1510315

Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot

Show all headers | View raw

On Thu, 27 Oct 2016, Grzegorz Andrejczuk wrote:
> +#ifdef CONFIG_X86_64
> +static int phi_r3mwait_disabled __read_mostly;
> +
> +static int __init phir3mwait_disable(char *__unused)
> +{
> +	phi_r3mwait_disabled = 1;
> +	pr_warn("x86/phir3mwait: Disabled ring 3 MWAIT for Xeon Phi");

Why would that be a warning? The sysadmin added the command line switch, so
why does he needs to be warned?

> +	return 1;
> +}
> +__setup("phir3mwait=disable", phir3mwait_disable);
> +
> +static void probe_xeon_phi_r3mwait(struct cpuinfo_x86 *c)
> +{
> +	u64 msr;
> +
> +	rdmsrl(MSR_PHI_MISC_THD_FEATURE, msr);
> +
> +	if (phi_r3mwait_disabled) {
> +		msr &= ~MSR_PHI_MISC_THD_FEATURE_R3MWAIT;
> +		wrmsrl(MSR_PHI_MISC_THD_FEATURE, msr);
> +	} else {
> +		msr |= MSR_PHI_MISC_THD_FEATURE_R3MWAIT;
> +		wrmsrl(MSR_PHI_MISC_THD_FEATURE, msr);
> +	}

	if (phi_r3mwait_disabled)
		msr &= ~MSR_PHI_MISC_THD_FEATURE_R3MWAIT;
	else
		msr |= MSR_PHI_MISC_THD_FEATURE_R3MWAIT;

	wrmsrl(MSR_PHI_MISC_THD_FEATURE, msr);

Would be too simple and obvious, right? You still can add the extra bits of
setting the capability flag into the else path.

>  	init_intel_energy_perf(c);
> +
> +	/*
> +	* Setting ring 3 MONITOR/MWAIT for thread
> +	* when CPU is Xeon Phi Family x200 (KnightsLanding).
> +	*/
> +	if (c->x86 == 6 && c->x86_model == INTEL_FAM6_XEON_PHI_KNL)

Please move this conditional into the probe function.

> +		probe_xeon_phi_r3mwait(c);

Can you please check with your hardware people, whether this function is
somewhere detectable. bit 0 of the MISC_*FEATURE* MSR (Ring 3 CPUID fault
enable) is detectable via the PLATFORM_INFO MSR. I would be surprised if
this thing is not detectable in some way.

I really prefer detectable things over hardcoded crap which depends on
model information.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/4] Enabling Ring 3 MONITOR/MWAIT feature for Knights Landing Grzegorz Andrejczuk <grzegorz.andrejczuk@intel.com> - 2016-10-27 16:10 +0200
  [PATCH v6: 4/4] x86/cpufeature: Add R3MWAIT to CPU features Grzegorz Andrejczuk <grzegorz.andrejczuk@intel.com> - 2016-10-27 16:10 +0200
    Re: [PATCH v6: 4/4] x86/cpufeature: Add R3MWAIT to CPU features Borislav Petkov <bp@suse.de> - 2016-10-27 16:40 +0200
      RE: [PATCH v6: 4/4] x86/cpufeature: Add R3MWAIT to CPU features "Andrejczuk, Grzegorz" <grzegorz.andrejczuk@intel.com> - 2016-10-27 18:50 +0200
        Re: [PATCH v6: 4/4] x86/cpufeature: Add R3MWAIT to CPU features Borislav Petkov <bp@suse.de> - 2016-10-27 19:10 +0200
  [PATCH v6: 1/4] x86/msr: Add R3MWAIT register and bit to msr-info.h Grzegorz Andrejczuk <grzegorz.andrejczuk@intel.com> - 2016-10-27 16:10 +0200
    Re: [PATCH v6: 1/4] x86/msr: Add R3MWAIT register and bit to  msr-info.h Thomas Gleixner <tglx@linutronix.de> - 2016-10-27 16:40 +0200
  [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot Grzegorz Andrejczuk <grzegorz.andrejczuk@intel.com> - 2016-10-27 16:10 +0200
    Re: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot Thomas Gleixner <tglx@linutronix.de> - 2016-10-27 16:50 +0200
      RE: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot "Andrejczuk, Grzegorz" <grzegorz.andrejczuk@intel.com> - 2016-10-27 19:00 +0200
        RE: [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot Thomas Gleixner <tglx@linutronix.de> - 2016-10-27 20:30 +0200
  [PATCH v6: 3/4] x86: Use HWCAP2 to expose Xeon Phi ring 3 MWAIT Grzegorz Andrejczuk <grzegorz.andrejczuk@intel.com> - 2016-10-27 16:10 +0200

csiph-web