Re: ARC-setup: Use seq_putc() in show_cpuinfo()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: ARC-setup: Use seq_putc() in show_cpuinfo()
Date	2016-10-17 19:50 +0200
Message-ID	<stkcW-6Af-19@gated-at.bofh.it> (permalink)
References	<ssDhD-3Mr-5@gated-at.bofh.it> <stiXv-5Qr-19@gated-at.bofh.it> <stjTz-6sY-33@gated-at.bofh.it> <stjTz-6sY-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>>> Perhaps reword the changelog to say that seqc_putc is more efficient than
>>> seqc_printf to output a single char.
>>> I mean _printf is not wrong but not as efficient ?
>> I came along source files for a few other software modules with similar
>> change possibilities.
>> Unfortunately, the corresponding developers are not convinced yet
>> to replace a call of the function "seq_printf" at the end by
>> a "seq_putc" because of software efficiency reasons.
> 
> I was ambivalent so far - but not anymore :-)

Interesting …


> what is the objection - can you point me to a few links where people don't think
> this is not a good idea.

Yes, of course. - Does the double negation in this wording indicate another
special software development concern?

How do you think about another update suggestion like "[PATCH] MD-RAID: Use seq_putc()
in three status functions" (from 2016-10-16)?
https://patchwork.kernel.org/patch/9378055/
https://lkml.kernel.org/r/<77fb6fdc-7480-8607-0af1-42f73c125b9d@users.sourceforge.net>


>> Do you find this update suggestion acceptable to some degree
>> for the function "setup"?

I am curious what your opinions will be for further development of the
function "show_cpuinfo" in the source file "arch/arc/kernel/setup.c".

Regards,
Markus

Thread

[PATCH] ARC-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-15 22:00 +0200
  Re: [PATCH] ARC-setup: Use seq_putc() in show_cpuinfo() Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-17 18:30 +0200
    Re: ARC-setup: Use seq_putc() in show_cpuinfo() Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-10-17 19:30 +0200
      Re: ARC-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-17 19:50 +0200
    Re: ARC-setup: Use seq_putc() in show_cpuinfo() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-10-17 19:30 +0200

csiph-web